Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not track default values for parameters if given as argument #236

Open
EagleoutIce opened this issue Aug 23, 2023 · 2 comments · May be fixed by #783
Open

Do not track default values for parameters if given as argument #236

EagleoutIce opened this issue Aug 23, 2023 · 2 comments · May be fixed by #783
Assignees
@Ellpeck
Labels
enhancement New feature or request static slicing Related to slicing the source code statically

Comments

@EagleoutIce
Copy link
Member

EagleoutIce commented Aug 23, 2023 •
edited
Loading

If we have something like f <- function(x=y) { x }, and two calls: f(3) and f(). The first one, does not require y, while the second one does. Currently, the static slicer includes and traces y both times. However, for the first call this is not necessary! We can potentially flag saturated arguments when visiting a function call.
@EagleoutIce EagleoutIce added enhancement New feature or request static slicing Related to slicing the source code statically labels Aug 23, 2023
@EagleoutIce
Copy link
Member Author

this should be tested, now that we have #526.

@EagleoutIce
Copy link
Member Author

related to #772

@EagleoutIce EagleoutIce assigned Ellpeck and EagleoutIce and unassigned Ellpeck May 6, 2024
@EagleoutIce EagleoutIce linked a pull request May 10, 2024 that will close this issue
do not track default values for parameters if given as argument #783
Draft
@EagleoutIce EagleoutIce assigned Ellpeck and unassigned EagleoutIce May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ellpeck Ellpeck

Labels
enhancement New feature or request static slicing Related to slicing the source code statically
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not track default values for parameters if given as argument flowr-analysis/flowr
2 participants
@Ellpeck @EagleoutIce