Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect NoteOff after changing octaves #9

Open
eclab opened this issue Nov 6, 2020 · 2 comments
Open

Incorrect NoteOff after changing octaves #9

eclab opened this issue Nov 6, 2020 · 2 comments
Labels

Comments

@eclab
Copy link

eclab commented Nov 6, 2020

  1. Hold down a key (say, "q") to play a note. A NOTE ON is signaled to begin playing that note.

  2. While holding down the key, press the RIGHT ARROW to shift up an octave.

  3. Let go of the ("q") key. The wrong NOTE OFF is signaled: it's the one to stop playing the note up one octave. The note is now permanently stuck on.

This works with left arrow too of course.

@flit flit added the bug label Nov 15, 2020
@flit
Copy link
Owner

flit commented Nov 15, 2020

Thanks for the bug report! I have some time coming up next month when I should be able to work on this.

@gsxdsm
Copy link

gsxdsm commented Dec 23, 2022

I was able to fix this. WIll submit a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants