Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISO 3166 to ISO 11784 and ISO 11785 animal reading in the 125 kHz RFID app #4044

Open
Jolexer opened this issue Dec 23, 2024 · 2 comments

Comments

@Jolexer
Copy link

Jolexer commented Dec 23, 2024

Describe the enhancement you're suggesting.

When reading an animal as described in https://docs.flipper.net/rfid/animal-microchips, the country code it displays is non-descript. These country codes are defined in ISO 3166 (wikipedia). Please display the country number along with the english country name in the full information display. In the abreviated info screen, it may be better to show the ISO 3166-A-2 country abbreviation also defined in that wikipedia page, instead of the full english name, to better fit the UI.

Below is a are current screenshots and their proposed versions:
Screenshot 2024-12-23 at 16 52 11
Screenshot 2024-12-23 at 16 52 11 edit
Screenshot 2024-12-23 at 17 28 11
Screenshot 2024-12-23 at 17 24 21 edit

Anything else?

I am really grateful that the flipper can read dog tags. Many people don't return collarless dogs because they don't want to bring them to a vet. Having given this feature to the flipper wil help many dogs find their owners.

@equipter
Copy link
Contributor

worth noting the first 3 digits "country code" are not always a country code.

https://mypethq.io/a-guide-to-pet-microchips/

so if this is added it might be worth it to replace country code with manufacturer code if the 3digit code found is not a country code.

@Jolexer
Copy link
Author

Jolexer commented Dec 23, 2024

worth noting the first 3 digits "country code" are not always a country code.

That is true, but they all start with 9xx. You could either put the mfg names in the list as well, or just display "invalid" instead of a country (which should be done for invalid codes anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants