Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't the per-project config file (/path/to/my/project/.npmrc) be in the .gitignore file #2

Open
cquezel opened this issue Jan 10, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@cquezel
Copy link

cquezel commented Jan 10, 2019

Shouldn't the per-project config file (/path/to/my/project/.npmrc) be in the .gitignore file?

Ref: https://docs.npmjs.com/files/npmrc.html

@flexdinesh
Copy link
Owner

@cquezel But we don't have .npmrc in our project. If you think it's important, would you like to create a PR on why we need that and add the file and it's entry in .gitignore?

@cquezel
Copy link
Author

cquezel commented Jan 28, 2019

I thought this was a "general" project for starting a npm module. The .npmrc file is a user per project configuration file used by npm. I think that most users would not want their personal configuration to be checked in to GIT or to use someone else's configuration which was accidentally checked in.

@flexdinesh
Copy link
Owner

You're right. I agree that this project should hightlight the use of .npmrc file. Feel free to create a PR or I can get to it in the next few days.

@flexdinesh flexdinesh added the help wanted Extra attention is needed label Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants