[GitOps] Error when using relative path in no-team.yml

[ksatter]

Fleetctl version: v4.62.0

---

💥  Actual behavior

With the following folder structure,

prod
  |-- lib
    |-- mdm-profiles
      |-- prod-profiles
        |-- profile.mobileconfig
  |-- teams
    |-- no-team.yml
    |-- test-team.yml
  |-- default.yml

Profiles listed in test-team.yml are succesfully applied using a relative path:

name: Test team
policies:
queries:
agent_options:
controls:
  macos_settings:
    custom_settings:
        - path: ../lib/mdm-profiles/prod-profiles/profile.mobileconfig
team_settings:
software:

But the same policy and path fails when applied to "no team":

name: No team
policies:
queries:
agent_options:
controls:
  macos_settings:
    custom_settings:
        - path: ../lib/mdm-profiles/prod-profiles/profile.mobileconfig
team_settings:
software:

The following error is returned:

Error: applying custom settings: open ../lib/mdm-profiles/prod-profiles/profile.mobileconfig: no such file or directory.

When no-team.yml is removed and only the test-team.yml is present, with the same relative path, settings are applied correctly without error.

Providing a full path to the file in the runner environment is also successful:

name: No team
policies:
queries:
controls:
  macos_settings:
    custom_settings:
        - path: /runner/_work/fleet-gitops/prod/lib/mdm-profiles/prod-profiles/profile.mobileconfig
agent_options:
team_settings:
software:

🧑‍💻  Steps to reproduce

1. TODO
2. TODO

🕯️ More info (optional)

N/A

It appears as though we do not include setting profiles for "No team" in our testing workflows, as per @getvictor, any solution should include setting up testing to detect additional issues with no-team.

🛠️ To fix

Product designer: @marko-lisica

• Support relative paths for no-team.yml file. It should work same way as in team files.

[JoStableford]

Linked to Unthread ticket:

Issue with gitops.sh script recognizing file paths #4263

[getvictor]

@ksatter I recall the customer had issues with macOS MDM profiles, not policies, correct?

[ksatter]

Thanks @getvictor, I guess my brain went in to autopilot when I built out the yaml. Updating now.