Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not log IllegalArgumentErrors as server errors #25759

Open
getvictor opened this issue Jan 24, 2025 · 0 comments
Open

Do not log IllegalArgumentErrors as server errors #25759

getvictor opened this issue Jan 24, 2025 · 0 comments
Assignees
@getvictor
Labels
~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. story A user story defining an entire feature
Milestone
4.64.0-tentative

Comments

@getvictor
Copy link
Member

getvictor commented Jan 24, 2025 •
edited
Loading

After the recent Sprint demo and backend sync, we decided NOT to log IllegalArgumentError as a server error. Since this is a client error, it will be logged at the debug level.

QA Testplan

This issue is a re-implementation of the fix for #25265

Repeat the tests done for #25265
@getvictor getvictor added #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. story A user story defining an entire feature ~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. labels Jan 24, 2025
@getvictor getvictor self-assigned this Jan 24, 2025
@getvictor getvictor added this to the 4.64.0-tentative milestone Jan 24, 2025
@getvictor getvictor mentioned this issue Jan 24, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getvictor getvictor

Labels
~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. story A user story defining an entire feature
Milestone
4.64.0-tentative
Development

No branches or pull requests
1 participant
@getvictor