You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We get a list of all saddle connections of length less than 10.
but which uses
sc_list=s.saddle_connections(10)
and so only goes up to squared length 10, i.e. up to length sqrt(10).
Ideally this method could use keyword arguments to offer a choice:
max_length=0
max_length_squared=0
max_combinatorial_length=0
If several of them are provided, we could combine the constraints
(or raise an error). Combining the constraints would allow to bound
both the combinatorial and geometric length in dilation surfaces.
The main advantage of using squared length is to avoid taking
square roots, but we can avoid it anyway by checking whether a^2 + b^2 < c^2 instead of checking whether sqrt(a^2 + b^2) < c.
It would also be nice to allow users to specify whether to use <= or < when checking against the provided bound.
The text was updated successfully, but these errors were encountered:
slel
changed the title
Provide several option for saddle_connections bound
Provide several options for saddle_connections bound
Jul 19, 2021
Either that, or use length_squared_less_than, length_squared_up_to, length_less_than, length_up_to, so all keywords in that family start with "length", and deprecate max_length.
saraedum
added a commit
to saraedum/sage-flatsurf
that referenced
this issue
Dec 11, 2024
The method
saddle_connections
has asquared_length_bound
argument.While in technical terms working with a bound on the squared length
has advantages, the user expects the bound to be on the length.
Even the saddle connections examples page trips over this at:
with an example phrased as
but which uses
and so only goes up to squared length 10, i.e. up to length sqrt(10).
Ideally this method could use keyword arguments to offer a choice:
max_length=0
max_length_squared=0
max_combinatorial_length=0
If several of them are provided, we could combine the constraints
(or raise an error). Combining the constraints would allow to bound
both the combinatorial and geometric length in dilation surfaces.
The main advantage of using squared length is to avoid taking
square roots, but we can avoid it anyway by checking whether
a^2 + b^2 < c^2
instead of checking whethersqrt(a^2 + b^2) < c
.It would also be nice to allow users to specify whether to use
<=
or<
when checking against the provided bound.The text was updated successfully, but these errors were encountered: