-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change naming convention for Flatpak manifest files #406
Comments
I'll just copy my comment from the flatpak-builder issue:
|
Hey @TingPing, thanks for your feedback. I didn't know that tooling depends on the exact file name, I thought, most tooling was agnostic to the exact file name (like flatpak-builder is). Only changing the suggestion when the community is on board sounds very reasonable. What would be your indicator to know whether the community is fine with a new convention? Which tools depend on the |
Flathub does. |
GNOME-Builder, and probably every other IDE (VSCode's extension?) |
Still, would be nice to have that for the tooling. I would be interested, if @bilelmoussaoui thought about this and has some insights |
Currently, the docs propose to name the manifest file
{appliction-id}.yaml
or{appliction-id}.json
. This makes sense when a repository (or directory) contains multiple manifests for different applications.However, the docs also propose to use this naming convention for their example, where the Flatpak manifest lives directly with the application itself in the same directory.
In such a case, this kind of file name is not very helpful: The information to which application the manifest belongs is already provided by the location of the file (the VCS repository) and by its contents (which also contains the application id). At least the file name provides the information that it is in yaml/json format, but it says nothing about its structure or meaning in the context of the repository.
This has the following disadvantages:
I propose the following convention instead:
If the target of the Flatpak manifest is unambigous given its location (e. g. the repository it lives in), simply call it
flatpak-manifest.yaml
/flatpak-manifest.json
. If there are multiple flatpak manifest files in the location, give it a prefix that tells it apart:nightly.flatpak-manifest.yaml
dependencies.flatpak-manifest.yaml
org.example.app.flatpak-manifest.yaml
)The advantages of this naming convention:
The text was updated successfully, but these errors were encountered: