From 17e847c73c155b9367c70adec25b87cb27d3c4bf Mon Sep 17 00:00:00 2001 From: Vibhor Dabas Date: Thu, 19 Oct 2023 16:55:22 +0530 Subject: [PATCH 1/2] fix: add the ability to disable cert manager crds --- pkg/phases/crds/install.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/phases/crds/install.go b/pkg/phases/crds/install.go index 6a98923d7..261a0b6f5 100644 --- a/pkg/phases/crds/install.go +++ b/pkg/phases/crds/install.go @@ -9,7 +9,7 @@ import ( func Install(p *platform.Platform) error { f := func() bool { return false } crds := map[string]func() bool{ - "cert-manager": f, + "cert-manager": func() bool { return !p.CertManager.Disabled }, "service-monitor": f, "canary-checker": p.CanaryChecker.IsDisabled, "template-operator": p.TemplateOperator.IsDisabled, From f15a4e5d39f8e497bc469444115fff0679aca13d Mon Sep 17 00:00:00 2001 From: Vibhor Dabas Date: Thu, 19 Oct 2023 18:19:53 +0530 Subject: [PATCH 2/2] fix: review fix --- pkg/phases/crds/install.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/phases/crds/install.go b/pkg/phases/crds/install.go index 261a0b6f5..6f7f9d005 100644 --- a/pkg/phases/crds/install.go +++ b/pkg/phases/crds/install.go @@ -9,7 +9,7 @@ import ( func Install(p *platform.Platform) error { f := func() bool { return false } crds := map[string]func() bool{ - "cert-manager": func() bool { return !p.CertManager.Disabled }, + "cert-manager": func() bool { return p.CertManager.Disabled }, "service-monitor": f, "canary-checker": p.CanaryChecker.IsDisabled, "template-operator": p.TemplateOperator.IsDisabled,