Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test check cancellation / db failure during shutdown #2221

Open
3 tasks
moshloop opened this issue Oct 10, 2024 · 1 comment · May be fixed by #2293
Open
3 tasks

Test check cancellation / db failure during shutdown #2221

moshloop opened this issue Oct 10, 2024 · 1 comment · May be fixed by #2293
Assignees
Labels
bug Something isn't working

Comments

@moshloop
Copy link
Member

moshloop commented Oct 10, 2024

A failed connection to the internal DB (e.g. during DB shutdown) could result in an increase of failed_count

  • Ensure failed db calls result in an invalid and not failed metric
  • Wait until all running checks have completed (or have been cancelled) before initiating the shutdown of the DB
    • For checks that require a non-trivial implementation to support cancellation, log backlogged bugs
@moshloop moshloop added the bug Something isn't working label Oct 10, 2024
@adityathebe
Copy link
Member

adityathebe commented Oct 24, 2024

Ensure failed db calls result in an invalid and not failed metric

@moshloop Is that invalid though? I think we should consider invalid if the spec is incorrect.

We probably need to add a distinction between an error and a check not passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants