A few minor fixes & new property's I added #4
Comments
|
Hi, I was wondering if there was a way to easily get your changes to this project? I'm not sure if you had pushed anything up that just wasn't merged or not but based on the dates of the project it does not look like your changes have been incorporated. Thanks, |
|
Dan, I will be happy to do this, but I am a newbie at working on a shared
GitHub project. I'll pull down a working copy of the repo and make the
changes, and submit them for review. Please give me a few days to figure
this out!
Gary
…On Wed, Aug 11, 2021 at 10:00 AM Dan Scott ***@***.***> wrote:
Hi,
I was wondering if there was a way to easily get your changes to this
project? I'm not sure if you had pushed anything up that just wasn't merged
or not but based on the dates of the project it does not look like your
changes have been incorporated.
Thanks,
Dan
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3Q5TJK4VS6PDDM6GTXY4TT4KUENANCNFSM473IEOOA>
.
|
|
Gary - no worries - if you push up changes I'm not sure they will get
merged - that is up to the owner to do that but I would definitely urge you
to push them at least. If they do not get merged then maybe I can get the
"changed" project from you a different way. We can cross that bridge when
we come to it though! Thanks for the effort all the same!!
…On Wed, Aug 11, 2021 at 3:37 PM Gary ***@***.***> wrote:
Dan, I will be happy to do this, but I am a newbie at working on a shared
GitHub project. I'll pull down a working copy of the repo and make the
changes, and submit them for review. Please give me a few days to figure
this out!
Gary
On Wed, Aug 11, 2021 at 10:00 AM Dan Scott ***@***.***> wrote:
> Hi,
>
> I was wondering if there was a way to easily get your changes to this
> project? I'm not sure if you had pushed anything up that just wasn't
merged
> or not but based on the dates of the project it does not look like your
> changes have been incorporated.
>
> Thanks,
> Dan
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#4 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AE3Q5TJK4VS6PDDM6GTXY4TT4KUENANCNFSM473IEOOA
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIBBEO45MZXZHKOGSR3XDDT4L3UPANCNFSM473IEOOA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
|
Dan, I have forked a copy of the project and added the Big Endian support,
so far so good. Need to add the Focus fix and the
AddressDisplayFormatProperty. I'll get that done within a day or so.
--Gary
…On Thu, Aug 12, 2021 at 8:46 AM Dan Scott ***@***.***> wrote:
Gary - no worries - if you push up changes I'm not sure they will get
merged - that is up to the owner to do that but I would definitely urge you
to push them at least. If they do not get merged then maybe I can get the
"changed" project from you a different way. We can cross that bridge when
we come to it though! Thanks for the effort all the same!!
On Wed, Aug 11, 2021 at 3:37 PM Gary ***@***.***> wrote:
> Dan, I will be happy to do this, but I am a newbie at working on a shared
> GitHub project. I'll pull down a working copy of the repo and make the
> changes, and submit them for review. Please give me a few days to figure
> this out!
>
> Gary
>
> On Wed, Aug 11, 2021 at 10:00 AM Dan Scott ***@***.***> wrote:
>
> > Hi,
> >
> > I was wondering if there was a way to easily get your changes to this
> > project? I'm not sure if you had pushed anything up that just wasn't
> merged
> > or not but based on the dates of the project it does not look like your
> > changes have been incorporated.
> >
> > Thanks,
> > Dan
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <
#4 (comment)
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AE3Q5TJK4VS6PDDM6GTXY4TT4KUENANCNFSM473IEOOA
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#4 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABIBBEO45MZXZHKOGSR3XDDT4L3UPANCNFSM473IEOOA
>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> or Android
> <
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3Q5TI6X4NN6YZTO35PTFLT4PUGXANCNFSM473IEOOA>
.
|
|
OK changes are pushed. Hopefully you can get them - I don't know if they
will get merged or not!
…On Sun, Aug 15, 2021 at 6:22 PM Gary Harris ***@***.***> wrote:
Dan, I have forked a copy of the project and added the Big Endian support,
so far so good. Need to add the Focus fix and the
AddressDisplayFormatProperty. I'll get that done within a day or so.
--Gary
On Thu, Aug 12, 2021 at 8:46 AM Dan Scott ***@***.***>
wrote:
> Gary - no worries - if you push up changes I'm not sure they will get
> merged - that is up to the owner to do that but I would definitely urge
> you
> to push them at least. If they do not get merged then maybe I can get the
> "changed" project from you a different way. We can cross that bridge when
> we come to it though! Thanks for the effort all the same!!
>
> On Wed, Aug 11, 2021 at 3:37 PM Gary ***@***.***> wrote:
>
> > Dan, I will be happy to do this, but I am a newbie at working on a
> shared
> > GitHub project. I'll pull down a working copy of the repo and make the
> > changes, and submit them for review. Please give me a few days to figure
> > this out!
> >
> > Gary
> >
> > On Wed, Aug 11, 2021 at 10:00 AM Dan Scott ***@***.***> wrote:
> >
> > > Hi,
> > >
> > > I was wondering if there was a way to easily get your changes to this
> > > project? I'm not sure if you had pushed anything up that just wasn't
> > merged
> > > or not but based on the dates of the project it does not look like
> your
> > > changes have been incorporated.
> > >
> > > Thanks,
> > > Dan
> > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub
> > > <
> #4 (comment)
> > >,
> > > or unsubscribe
> > > <
> >
> https://github.com/notifications/unsubscribe-auth/AE3Q5TJK4VS6PDDM6GTXY4TT4KUENANCNFSM473IEOOA
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <
> #4 (comment)>,
> > or unsubscribe
> > <
> https://github.com/notifications/unsubscribe-auth/ABIBBEO45MZXZHKOGSR3XDDT4L3UPANCNFSM473IEOOA
> >
> > .
> > Triage notifications on the go with GitHub Mobile for iOS
> > <
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > or Android
> > <
> https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
> >
> > .
> >
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#4 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE3Q5TI6X4NN6YZTO35PTFLT4PUGXANCNFSM473IEOOA>
> .
>
|
|
Hi Gary,
Thank you very much for this! If the owner of the repository does not merge
in the code do you think you could zip it up for me so that I can get it
from you?
Thanks again,
Dan
…On Sun, Aug 15, 2021 at 8:12 PM Gary ***@***.***> wrote:
OK changes are pushed. Hopefully you can get them - I don't know if they
will get merged or not!
On Sun, Aug 15, 2021 at 6:22 PM Gary Harris ***@***.***> wrote:
> Dan, I have forked a copy of the project and added the Big Endian
support,
> so far so good. Need to add the Focus fix and the
> AddressDisplayFormatProperty. I'll get that done within a day or so.
> --Gary
>
> On Thu, Aug 12, 2021 at 8:46 AM Dan Scott ***@***.***>
> wrote:
>
>> Gary - no worries - if you push up changes I'm not sure they will get
>> merged - that is up to the owner to do that but I would definitely urge
>> you
>> to push them at least. If they do not get merged then maybe I can get
the
>> "changed" project from you a different way. We can cross that bridge
when
>> we come to it though! Thanks for the effort all the same!!
>>
>> On Wed, Aug 11, 2021 at 3:37 PM Gary ***@***.***> wrote:
>>
>> > Dan, I will be happy to do this, but I am a newbie at working on a
>> shared
>> > GitHub project. I'll pull down a working copy of the repo and make the
>> > changes, and submit them for review. Please give me a few days to
figure
>> > this out!
>> >
>> > Gary
>> >
>> > On Wed, Aug 11, 2021 at 10:00 AM Dan Scott ***@***.***> wrote:
>> >
>> > > Hi,
>> > >
>> > > I was wondering if there was a way to easily get your changes to
this
>> > > project? I'm not sure if you had pushed anything up that just wasn't
>> > merged
>> > > or not but based on the dates of the project it does not look like
>> your
>> > > changes have been incorporated.
>> > >
>> > > Thanks,
>> > > Dan
>> > >
>> > > —
>> > > You are receiving this because you authored the thread.
>> > > Reply to this email directly, view it on GitHub
>> > > <
>> #4 (comment)
>> > >,
>> > > or unsubscribe
>> > > <
>> >
>>
https://github.com/notifications/unsubscribe-auth/AE3Q5TJK4VS6PDDM6GTXY4TT4KUENANCNFSM473IEOOA
>> > >
>> > > .
>> > >
>> >
>> > —
>> > You are receiving this because you commented.
>> > Reply to this email directly, view it on GitHub
>> > <
>> #4 (comment)
>,
>> > or unsubscribe
>> > <
>>
https://github.com/notifications/unsubscribe-auth/ABIBBEO45MZXZHKOGSR3XDDT4L3UPANCNFSM473IEOOA
>> >
>> > .
>> > Triage notifications on the go with GitHub Mobile for iOS
>> > <
>>
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>> >
>> > or Android
>> > <
>>
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
>> >
>> > .
>> >
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <
#4 (comment)>,
>> or unsubscribe
>> <
https://github.com/notifications/unsubscribe-auth/AE3Q5TI6X4NN6YZTO35PTFLT4PUGXANCNFSM473IEOOA
>
>> .
>>
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIBBELRXDAT7WMDLDUW4GLT5B6YFANCNFSM473IEOOA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
|
Dan, no problem I’m happy to do that for you. I think i can use your
account info to do this.
…On Mon, Aug 16, 2021 at 7:15 AM Dan Scott ***@***.***> wrote:
Hi Gary,
Thank you very much for this! If the owner of the repository does not merge
in the code do you think you could zip it up for me so that I can get it
from you?
Thanks again,
Dan
On Sun, Aug 15, 2021 at 8:12 PM Gary ***@***.***> wrote:
> OK changes are pushed. Hopefully you can get them - I don't know if they
> will get merged or not!
>
> On Sun, Aug 15, 2021 at 6:22 PM Gary Harris ***@***.***> wrote:
>
> > Dan, I have forked a copy of the project and added the Big Endian
> support,
> > so far so good. Need to add the Focus fix and the
> > AddressDisplayFormatProperty. I'll get that done within a day or so.
> > --Gary
> >
> > On Thu, Aug 12, 2021 at 8:46 AM Dan Scott ***@***.***>
> > wrote:
> >
> >> Gary - no worries - if you push up changes I'm not sure they will get
> >> merged - that is up to the owner to do that but I would definitely
urge
> >> you
> >> to push them at least. If they do not get merged then maybe I can get
> the
> >> "changed" project from you a different way. We can cross that bridge
> when
> >> we come to it though! Thanks for the effort all the same!!
> >>
> >> On Wed, Aug 11, 2021 at 3:37 PM Gary ***@***.***> wrote:
> >>
> >> > Dan, I will be happy to do this, but I am a newbie at working on a
> >> shared
> >> > GitHub project. I'll pull down a working copy of the repo and make
the
> >> > changes, and submit them for review. Please give me a few days to
> figure
> >> > this out!
> >> >
> >> > Gary
> >> >
> >> > On Wed, Aug 11, 2021 at 10:00 AM Dan Scott ***@***.***> wrote:
> >> >
> >> > > Hi,
> >> > >
> >> > > I was wondering if there was a way to easily get your changes to
> this
> >> > > project? I'm not sure if you had pushed anything up that just
wasn't
> >> > merged
> >> > > or not but based on the dates of the project it does not look like
> >> your
> >> > > changes have been incorporated.
> >> > >
> >> > > Thanks,
> >> > > Dan
> >> > >
> >> > > —
> >> > > You are receiving this because you authored the thread.
> >> > > Reply to this email directly, view it on GitHub
> >> > > <
> >>
#4 (comment)
> >> > >,
> >> > > or unsubscribe
> >> > > <
> >> >
> >>
>
https://github.com/notifications/unsubscribe-auth/AE3Q5TJK4VS6PDDM6GTXY4TT4KUENANCNFSM473IEOOA
> >> > >
> >> > > .
> >> > >
> >> >
> >> > —
> >> > You are receiving this because you commented.
> >> > Reply to this email directly, view it on GitHub
> >> > <
> >>
#4 (comment)
> >,
> >> > or unsubscribe
> >> > <
> >>
>
https://github.com/notifications/unsubscribe-auth/ABIBBEO45MZXZHKOGSR3XDDT4L3UPANCNFSM473IEOOA
> >> >
> >> > .
> >> > Triage notifications on the go with GitHub Mobile for iOS
> >> > <
> >>
>
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >> >
> >> > or Android
> >> > <
> >>
>
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
> >> >
> >> > .
> >> >
> >>
> >> —
> >> You are receiving this because you authored the thread.
> >> Reply to this email directly, view it on GitHub
> >> <
> #4 (comment)
>,
> >> or unsubscribe
> >> <
>
https://github.com/notifications/unsubscribe-auth/AE3Q5TI6X4NN6YZTO35PTFLT4PUGXANCNFSM473IEOOA
> >
> >> .
> >>
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#4 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABIBBELRXDAT7WMDLDUW4GLT5B6YFANCNFSM473IEOOA
>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> or Android
> <
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3Q5TLCMLSSQI2YIY4ZLD3T5EMOTANCNFSM473IEOOA>
.
|
|
@Hogflash / @ttrfanatic feel free to submit a PR with your changes. I'm happy to merge them into the repository. Thanks! Also apologies as I somehow had custom notifications on this repo and I wasn't aware of the discussion here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First off, thanks for an excellent control, this is very nicely done & documented! I found the following two bugs which were easily corrected:
verticalScrollBar.LargeChange = MaxVisibleRows; is set before MaxVisibleRows is determined, and thus is zero. I moved this to the UpdateMaxVisibleRowsAndColumns() function, and it appears to work as intended now.
In the function ReadFormattedData() case DataType.FloatingPoint where DataWidth == 8 correctly extracts 8 bytes, but converts them to a single. I think this should be a double.
I also added a few new properties:
DataEndianProperty : This allows specifying big or little endian for the stream. This is implemented using an extension method for the BinaryReader that handles the byte order swaps as needed. I modified the code in the ReadFormattedData to use this property. I also added Big/Little Endian checkbox in the context menu.
AddressDisplayFormatProperty : This configures the address column format allowing various alternate widths and formats, 16, 24, 32, 48 and 64 bit. This just improves readability for the more common small files, if desired. Required a new function GetFormattedAddressText(ulong Addr64) and modification to CalculateAddressColumnCharWidth()
Interestingly, I was able to back-port this to NET Framework 4.0 with minimal issues (mostly namespace changes). This lets me incorporate the control into some older projects! It IS a bit slower, but still performs well.
Now, one more thing I would like to do is programmatically select a block of data based on a start and end address. I'm not seeing any easy way to implement this, do you have any suggestions of how this should be approached?
Thanks, Gary
EDIT:
I WAS able to programmatically select a block; I had accidently specified the same start and end address which results in NO selection! I assume the reason the properties are private is because some validation is desired before externally setting them.
One other item: I added an OnMouseEnter event override that sets the focus to the control. Otherwise, if the control is hosted in a form that can receive focus, the control's keyboard events will be lost and not reconnected once the host takes the focus. Of course, there are other ways to handle this but this works!
The text was updated successfully, but these errors were encountered: