Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sent /script commands #29

Open
Suzaru opened this issue Feb 7, 2020 · 1 comment
Open

Sent /script commands #29

Suzaru opened this issue Feb 7, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@Suzaru
Copy link

Suzaru commented Feb 7, 2020

Hey there!

Thank you very much for your work. We love it in our guild.

I tried to find a way to send "/SCRIPT" commands. For example to set a Gmotd. Is there any way to do that? Or any chance you could include that?

Thank you again!
Suzu

@fjaros
Copy link
Owner

fjaros commented Feb 8, 2020

Hi Suzaru, thanks for the feedback. It's a good idea but it requires a bit more thought than is immediately apparent:

  1. It is not as simple as just sending "/gmotd stuff" as a chat message to the server. In fact, it requires the bot to realize you are trying to set the gmotd and send the request to server in a special way using the gmotd packet. This is actually not a big deal, the bot could do this, I am just highlighting that "/SCRIPT" commands are not a general chat message.
  2. Let's assume that we implement a way for the bot to send many /SCRIPT commands, including /gmotd. You'd have to make the bot an officer in your guild. Since the bot internally does not keep an access list, anyone who can talk in the discord channel could promote/demote people, set gmotd, kick people out of the guild, etc... This is obviously a huge security hole so we would have to implement an access list or maybe some other system like only if you send /SCRIPT commands in a discord "officers" channel where only officers can send messages, it would respect them. Personally, I would probably choose the discord channel route, since it is in the spirit of the project to let Discord control the different permissions.

In any case I have no plans to continue development at this time since I no longer play on private servers, but of course I'm always happy to help others make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants