Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Latest commit

 

History

History
129 lines (90 loc) · 3.81 KB

CONTRIBUTING.md

File metadata and controls

129 lines (90 loc) · 3.81 KB

Contributing

We want this community to be friendly and respectful to each other. Please follow it in all your interactions with the project.

Development workflow

To get started with the project, run yarn in the root directory to install the required dependencies for each package:

yarn

While it's possible to use npm, the tooling is built around yarn, so you'll have an easier time if you use yarn for development.

While developing, you can run the example app to test your changes. Any changes you make in your library's JavaScript code will be reflected in the example app without a rebuild. If you change any native code, then you'll need to rebuild the example app.

To start the packager:

yarn example start

To run the example app on Android:

yarn example android

To run the example app on iOS:

yarn example ios

Make sure your code passes TypeScript and ESLint. Run the following to verify:

yarn typescript
yarn lint:check

To fix formatting errors, run the following:

yarn lint:fix

Remember to add tests for your change if possible. Run the unit tests by:

yarn test

To edit the Swift files, open example/ios/MembraneExample.xcworkspace in XCode and find the source files at Pods > Development Pods > react-native-client-sdk.

To edit the Kotlin files, open examples/video-chat/android in Android studio and find the source files at reactnativemembrane under Android.

Commit message convention

We follow the conventional commits specification for our commit messages:

  • fix: bug fixes, e.g. fix crash due to deprecated method.
  • feat: new features, e.g. add new method to the module.
  • refactor: code refactor, e.g. migrate from class components to hooks.
  • docs: changes into documentation, e.g. add usage example for the module..
  • test: adding or updating tests, e.g. add integration tests using detox.
  • chore: tooling changes, e.g. change CI config.

Our pre-commit hooks verify that your commit message matches this format when committing.

Linting and tests

ESLint, Prettier, TypeScript

We use TypeScript for type checking, ESLint with Prettier for linting and formatting the code, and Jest for testing.

Our pre-commit hooks verify that the linter and tests pass when committing.

Publishing to npm

Releasing via GitHub Actions

To release a new version of the package, navigate to Actions > Release package workflow and trigger it with the chosen release type. The workflow will update the package version in package.json, release the package to NPM, create a new git tag and a GitHub release.

Releasing manually

We use release-it to make it easier to publish new versions manually. It handles common tasks like bumping version based on semver, creating tags and releases etc.

To publish a new version, run the following:

yarn release

Sending a pull request

Working on your first pull request? You can learn how from this free series: How to Contribute to an Open Source Project on GitHub.

When you're sending a pull request:

  • Prefer small pull requests focused on one change.
  • Verify that linters and tests are passing.
  • Review the documentation to make sure it looks good.
  • Follow the pull request template when opening a pull request.
  • For pull requests that change the API or implementation, discuss with maintainers first by opening an issue.