Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change price presicion to 4? #346

Open
sreichel opened this issue Apr 18, 2019 · 4 comments
Open

Change price presicion to 4? #346

sreichel opened this issue Apr 18, 2019 · 4 comments

Comments

@sreichel
Copy link
Contributor

Magesetup is made for localized market, so I hope this could move in ;)

Our settings:

  • different websites
  • splitted for B2C/B2C
  • price are stored w/o VAT, but
  • tax setting to include 19% VAT for B2C stores
  • tax setting NOT to include 19% VAT for B2C stores

This breaks correct price calculation for carts with multiple items and leads to "Supected fraud" errors for Paypal payments. With changing presion to 4 we could nealy solve most of this ... only Paypay needs an additionl fix for 0,01€ rounding.

W/o paypal fix ... https://magento.stackexchange.com/a/270713/46249

Ideas?

@Schrank
Copy link
Member

Schrank commented Apr 19, 2019

Good morning, unfortunately I haven’t fibd a proper fix until now, because we don’t know how PayPal is doing it’s calculations exactly.

If you don’t submit cart line items, this solves the problem but kills seller protection.

Which Magento version are you running on? The current has much lower probability for rounding issues. But it isn’t fixed.

@Schrank
Copy link
Member

Schrank commented Apr 19, 2019

There is a module you might want to try/ PR int: https://github.com/magento-hackathon/PaypalRoundBugfix

@Schrank
Copy link
Member

Schrank commented Apr 19, 2019

Obviously the module isn’t doing what I hoped, but improving it is a thing 😂

@sreichel
Copy link
Contributor Author

If you don’t submit cart line items, this solves the problem but kills seller protection.

Which Magento version are you running on? The current has much lower probability for rounding issues. But it isn’t fixed.

Good morning ;) We use 1.9.4.x (LTS) and work with 4 decimals since 1.5. If i remember right PayPal issues came with 1.9. We've "fixed" it similiar to this https://www.kreativundsoehne.de/blog/magento-rundungsfehler-in-version-1-9-x.html (check if diff is 0,01€ and adjust paypal value)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants