Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Genkit requires skipLibCheck to work #1591

Open
11 of 17 tasks
inlined opened this issue Jan 7, 2025 · 2 comments
Open
11 of 17 tasks

[JS] Genkit requires skipLibCheck to work #1591

inlined opened this issue Jan 7, 2025 · 2 comments
Assignees
Labels
bug Something isn't working js

Comments

@inlined
Copy link
Member

inlined commented Jan 7, 2025

Describe the bug
Consumers of Genkit must use skipLibCheck to use Genkit. This also affects authors of Genkit as turning on skipLibCheck has hidden compiler errors between packages in this workspace

To Reproduce
Use Genkit in an application that does not have skipLibCheck: true

Expected behavior
Ideally, skipLibCheck is not forced onto our customers

Runtime (please complete the following information):

  • OS: MacOS
  • Version 14.7.2

Node version

  • 22

Additional context
Currently compiled with skipLibCheck off (will be updated as fixes are committed):

  • genkit
  • @genkit-ai/ai
  • @genkit-ai/core
  • @genkit-ai/checks
  • @genkit-ai/chroma
  • @genkit-ai/dev-local-vectorstore
  • @genkit-ai/dotprompt
  • @genkit-ai/evaluators
  • @genkit-ai/express
  • @genkit-ai/firebase
  • @genkit-ai/google-cloud
  • @genkit-ai/googleai
  • @genkit-ai/langchain
  • @genkit-ai/mcp
  • @genkit-ai/ollama
  • @genkit-ai/pinecone
  • @genkit-ai/vertexai
@chrisraygill
Copy link
Contributor

@inlined what's the latest status here? Anything to do ahead of 1.0?

@inlined
Copy link
Member Author

inlined commented Jan 16, 2025

Just committed a change and updated the checklist. firebase and google-cloud should work now that the long maintainers committed a fix, but it broke in CI/CD and I reverted. We can follow up with fixes for those. As a chore, we can also file bugs or suggest fixes to the other SDKs. Our tsconfig lists the errors we're running into in each library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working js
Projects
Status: No status
Development

No branches or pull requests

2 participants