Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Groups: add support for aliases #6738

Closed
davidwatkins73 opened this issue Aug 29, 2023 · 6 comments
Closed

App Groups: add support for aliases #6738

davidwatkins73 opened this issue Aug 29, 2023 · 6 comments
Assignees
Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Milestone

Comments

@davidwatkins73
Copy link
Member

Description

Include in search.

Idea is that we can swap over the names of the auto groups.

Resourcing

We intend to contribute this feature

@davidwatkins73 davidwatkins73 added the noteworthy probably worth mentioning in release notes label Aug 29, 2023
@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Aug 31, 2023

Tasks:

  • figure out how to copy the aliases widget from application overview to app-group overview
  • ensure the back-end can persist/retrieve changes
  • (bonus) port to svelte and decom existing code if possible
  • ensure the aliases are used when searching
  • ensure changelog entries are written when a user edits aliases
  • NEW: cleanup changelog entry message
  • NEW: ensure user has permissions

@davidwatkins73 davidwatkins73 self-assigned this Sep 3, 2023
@davidwatkins73
Copy link
Member Author

Alias changes are recorded in the changelog, but the message is a but ugly:

Updated alias, entity: EntityReference{kind=APPLICATION, id=10, entityLifecycleStatus=ACTIVE}, new aliases: [test], user: admin

@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Sep 3, 2023

Looks like server-side permissioning is not enforced, should probably be a new issue as probably impacts tags as well.

@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Sep 3, 2023

Doing the search efficiently may be tricky. The AppGroupDao::search method already does a union seach for private and public groups. Using aliases would require two more parts to the union (private-aliases and public-aliases).

Not sure if we can do better.

davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Sep 6, 2023
@davidwatkins73 davidwatkins73 added the waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream label Sep 6, 2023
@davidwatkins73
Copy link
Member Author

Decided to just add two more branches to the union query. One for public groups via alias and one for private groups via alias.

davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Sep 11, 2023
@davidwatkins73
Copy link
Member Author

Adding Aliases

Starting from an app group page, click on the Aliases: ... add one link:

1_initial-group

You can add multiple aliases. Each time you add an alias it is saved immediately to the database, a confirmation notification will also be displayed.

2_added-alias

When you have finished adding aliases click on the close link to see the saved aliases.

3_view-alias

Searching

Groups can now be searched for by their alias names. Note: the result shown gives the primary name for the group, not the alias.

5_search-result

@jessica-woodland-scott-db jessica-woodland-scott-db added fixed (test & close) An issue has been fixed, merged into master and is ready for further testing and removed waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream labels Sep 12, 2023
@davidwatkins73 davidwatkins73 modified the milestones: done : 1.54, 1.54 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Projects
None yet
Development

No branches or pull requests

2 participants