Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow resurrection #6737

Closed
davidwatkins73 opened this issue Aug 29, 2023 · 2 comments
Closed

Flow resurrection #6737

davidwatkins73 opened this issue Aug 29, 2023 · 2 comments
Assignees
@davidwatkins73
Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Milestone
1.54

Comments

@davidwatkins73
Copy link
Member

Description

Admins should be able to restore removed logical and physical flows. If restoring logical's it should offer to restore associated physicals, and if restoring physicals it must ensure the logical is active.

Resourcing

We intend to contribute this feature
@davidwatkins73 davidwatkins73 added the noteworthy probably worth mentioning in release notes label Aug 29, 2023
@davidwatkins73 davidwatkins73 self-assigned this Sep 21, 2023
@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Sep 21, 2023 •
edited
Loading

Rough task list:

  • Service/Dao methods to restore:
    • logical flow
    • physical flow
    • spec and co.
  • Figure out how to propagate a phys flow restore to the assoc spec and logical
  • Endpoints
  • UI integration
  • Tests

deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Sep 25, 2023
@db-waltz
Resurrect flow
6ab8cd2 
- ensure flows are correctly marked as inactive (was ignoring the is_removed prop)

#CTCTOWALTZ-2882
finos#6737
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Sep 25, 2023
@db-waltz
Resurrect flow
41ee0bf 
- restore flows (and remove them) from the view page

#CTCTOWALTZ-2882
finos#6737
@davidwatkins73 davidwatkins73 mentioned this issue Sep 25, 2023
Merged
@davidwatkins73
Copy link
Member Author

Propagation not really needed. Instead, when we restore a logical flow, the active (at the time or removal) phys flows should become 'reachable'.

@davidwatkins73 davidwatkins73 added the fixed (test & close) An issue has been fixed, merged into master and is ready for further testing label Sep 25, 2023
@davidwatkins73 davidwatkins73 modified the milestones: done : 1.54, 1.54 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwatkins73 davidwatkins73

Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Projects
None yet
Milestone
1.54
Development

No branches or pull requests
1 participant
@davidwatkins73