Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measurable Category: should support a static panel with information above the diagrams #6710

Closed
jessica-woodland-scott-db opened this issue Aug 17, 2023 · 2 comments
Closed

Measurable Category: should support a static panel with information above the diagrams #6710

jessica-woodland-scott-db opened this issue Aug 17, 2023 · 2 comments
Assignees
@jessica-woodland-scott-db
Labels
DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database fixed (test & close) An issue has been fixed, merged into master and is ready for further testing small change Should be a simple, low complexity issue
Milestone
1.53

Comments

@jessica-woodland-scott-db
Copy link
Contributor

Description

Option to move the existing 'About' static panel or create a new one.

May need to move the exports under tree

Resourcing

We would like to add this request to the Waltz team's feature backlog
@jessica-woodland-scott-db jessica-woodland-scott-db added the small change Should be a simple, low complexity issue label Aug 17, 2023
@jessica-woodland-scott-db jessica-woodland-scott-db added this to the todo : 1.53 milestone Aug 17, 2023
@davidwatkins73
Copy link
Member

davidwatkins73 commented Aug 18, 2023 •
edited
Loading

Moving the panel looks good, however the static panel titles look a bit out of place.
Decided the best solution is to make static panel optionally render a title based on the presence of the static_panel::title value in the database. This in turn means we will need to updated the DDL (the column is currently non-nullable) and update the static panel admin screens to relax the required constraint.

Adding the DDL tag to this issue

@davidwatkins73 davidwatkins73 added the DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database label Aug 18, 2023
@davidwatkins73
Copy link
Member

Now that panel titles are nullable, we need something better to show in the panel list. Decision is to show the title and fallback to showing an italicized version of the first 50 chars of the content if the title is not available.

@davidwatkins73 davidwatkins73 added the waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream label Aug 18, 2023
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Aug 21, 2023
@jessica-woodland-scott-db
Reorganise measurbale view page
eb16a48 
- allow static pnale title and icon to be nullable

#CTCTOWALTZ-2823
finos#6710
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Aug 21, 2023
@jessica-woodland-scott-db
Reorganise measurable view page
dfff5e4 
- tidy up static panel list

#CTCTOWALTZ-2823
finos#6710
This was referenced Aug 21, 2023
Merged
Merged
@davidwatkins73 davidwatkins73 added fixed (test & close) An issue has been fixed, merged into master and is ready for further testing and removed waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream labels Aug 22, 2023
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Aug 25, 2023
@jessica-woodland-scott-db
Reorganise measurable view page
779ab1c 
- tidy up static panel list

#CTCTOWALTZ-2823
finos#6710
@davidwatkins73 davidwatkins73 modified the milestones: done : 1.53, 1.53 Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessica-woodland-scott-db jessica-woodland-scott-db

Labels
DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database fixed (test & close) An issue has been fixed, merged into master and is ready for further testing small change Should be a simple, low complexity issue
Projects
None yet
Milestone
1.53
Development

No branches or pull requests
2 participants
@davidwatkins73 @jessica-woodland-scott-db