From e59ae7a23cda150392705c0df15fa792515d3ff8 Mon Sep 17 00:00:00 2001
From: David Watkins <davidwatkins73@gmail.com>
Date: Thu, 27 Jul 2023 21:14:34 +0100
Subject: [PATCH 1/2] Change Initiatives: incomplete assessments filters

#6687
---
 .../ChangeInitiativeView.java                 |  20 +++
 .../client/assessments/assessment-utils.js    |  45 +----
 .../change-initiative-section.html            |  12 +-
 .../change-initiative-section.js              | 155 ++++++++++++------
 waltz-ng/client/change-initiative/index.js    |  14 +-
 .../services/change-initiative-view-store.js  |  57 +++++++
 .../client/common/services/core-api-utils.js  |   6 +-
 .../ChangeInitiativeViewService.java          | 124 ++++++++++++++
 .../api/ChangeInitiativeViewEndpoint.java     |  60 +++++++
 9 files changed, 391 insertions(+), 102 deletions(-)
 create mode 100644 waltz-model/src/main/java/org/finos/waltz/model/change_initiative/ChangeInitiativeView.java
 create mode 100644 waltz-ng/client/change-initiative/services/change-initiative-view-store.js
 create mode 100644 waltz-service/src/main/java/org/finos/waltz/service/change_initiative/ChangeInitiativeViewService.java
 create mode 100644 waltz-web/src/main/java/org/finos/waltz/web/endpoints/api/ChangeInitiativeViewEndpoint.java

diff --git a/waltz-model/src/main/java/org/finos/waltz/model/change_initiative/ChangeInitiativeView.java b/waltz-model/src/main/java/org/finos/waltz/model/change_initiative/ChangeInitiativeView.java
new file mode 100644
index 0000000000..1c7240de5e
--- /dev/null
+++ b/waltz-model/src/main/java/org/finos/waltz/model/change_initiative/ChangeInitiativeView.java
@@ -0,0 +1,20 @@
+package org.finos.waltz.model.change_initiative;
+
+import com.fasterxml.jackson.databind.annotation.JsonSerialize;
+import org.finos.waltz.model.assessment_definition.AssessmentDefinition;
+import org.finos.waltz.model.assessment_rating.AssessmentRating;
+import org.finos.waltz.model.rating.RatingSchemeItem;
+import org.immutables.value.Value;
+
+import java.util.Set;
+
+@Value.Immutable
+@JsonSerialize(as=ImmutableChangeInitiativeView.class)
+public abstract class ChangeInitiativeView {
+
+    public abstract Set<ChangeInitiative> changeInitiatives();
+    public abstract Set<AssessmentDefinition> assessmentDefinitions();
+    public abstract Set<RatingSchemeItem> ratingSchemeItems();
+    public abstract Set<AssessmentRating> ratings();
+
+}
diff --git a/waltz-ng/client/assessments/assessment-utils.js b/waltz-ng/client/assessments/assessment-utils.js
index d8069d6739..6549f2258b 100644
--- a/waltz-ng/client/assessments/assessment-utils.js
+++ b/waltz-ng/client/assessments/assessment-utils.js
@@ -17,8 +17,6 @@
  */
 import _ from "lodash";
 import { indexRatingSchemes } from "../ratings/rating-utils";
-import { nest } from "d3-collection";
-import { grey } from "../common/colors";
 import { refToString } from "../common/entity-utils";
 import {CORE_API} from "../common/services/core-api-utils";
 import {resolveResponses} from "../common/promise-utils";
@@ -70,48 +68,6 @@ export function mkEnrichedAssessmentDefinitions(definitions = [],
 }
 
 
-export function mkAssessmentSummaries(definitions = [], schemes = [], ratings = [], total = 0) {
-    const indexedRatingSchemes = indexRatingSchemes(schemes);
-    const definitionsById = _.keyBy(definitions, d => d.id);
-
-    const nestedRatings = nest()
-        .key(d => d.assessmentDefinitionId)
-        .key(d => d.ratingId)
-        .rollup(xs => xs.length)
-        .entries(ratings);
-
-    return _
-        .chain(nestedRatings)
-        .map(d => {
-            const definition = definitionsById[Number(d.key)];
-            const assignedTotal = _.sumBy(d.values, v => v.value);
-            const values = _
-                .chain(d.values)
-                .map(v => {
-                    const propPath = [definition.ratingSchemeId, "ratingsById", v.key];
-                    const rating = _.get(indexedRatingSchemes, propPath);
-                    return Object.assign({}, v, { rating, count: v.value });
-                })
-                .concat([{
-                    key: "z",
-                    rating: {
-                        id: -1,
-                        name: "Not Provided",
-                        color: grey
-                    },
-                    count: _.max([0, total - assignedTotal])
-                }])
-                .filter(d => d.count > 0)
-                .value();
-
-            const extension = { definition, values };
-            return Object.assign({}, d , extension);
-        })
-        .orderBy(d => d.definition.name)
-        .value();
-}
-
-
 /**
  * Given a list of entities, a list of assessment ratings and a desired
  * rating will filter the list of entities accordingly
@@ -154,6 +110,7 @@ export function filterByAssessmentRating(entities = [],
  * @param $q
  * @param serviceBroker
  * @param kind
+ * @param options
  * @param primaryOnly
  * @returns {*}
  */
diff --git a/waltz-ng/client/change-initiative/components/change-initiative-section/change-initiative-section.html b/waltz-ng/client/change-initiative/components/change-initiative-section/change-initiative-section.html
index d7c27dacfa..f40d6b63e6 100644
--- a/waltz-ng/client/change-initiative/components/change-initiative-section/change-initiative-section.html
+++ b/waltz-ng/client/change-initiative/components/change-initiative-section/change-initiative-section.html
@@ -15,9 +15,19 @@
   ~ See the License for the specific
   ~
   -->
+<style>
+    .wcis-inactive-ci {
+        color: #999;
+        font-style: italic;
+    }
 
-<div>
+    .wcis-inactive-ci a {
+        color: #777;
+        font-style: italic;
+    }
+</style>
 
+<div>
     <waltz-section-actions>
         <button class="btn btn-xs waltz-btn-transparent"
                 ng-click="$ctrl.visibility.sourcesOverlay = ! $ctrl.visibility.sourcesOverlay">
diff --git a/waltz-ng/client/change-initiative/components/change-initiative-section/change-initiative-section.js b/waltz-ng/client/change-initiative/components/change-initiative-section/change-initiative-section.js
index 91614bf857..7175b89430 100644
--- a/waltz-ng/client/change-initiative/components/change-initiative-section/change-initiative-section.js
+++ b/waltz-ng/client/change-initiative/components/change-initiative-section/change-initiative-section.js
@@ -18,17 +18,18 @@
 
 import _ from "lodash";
 
-import { CORE_API } from "../../../common/services/core-api-utils";
-import { initialiseData } from "../../../common";
-import { mkSelectionOptions } from "../../../common/selector-utils";
+import {CORE_API} from "../../../common/services/core-api-utils";
+import {initialiseData} from "../../../common";
 
 import template from "./change-initiative-section.html";
-import { changeInitiative } from "../../../common/services/enums/change-initiative";
-import { getEnumName } from "../../../common/services/enums";
+import {changeInitiative} from "../../../common/services/enums/change-initiative";
+import {getEnumName} from "../../../common/services/enums";
 import indexByKeyForType from "../../../enum-value/enum-value-utilities";
 import {isSameParentEntityRef} from "../../../common/entity-utils";
-import { fakeInitiative, fakeProgramme } from "../../change-initiative-utils";
-import { filterByAssessmentRating, mkAssessmentSummaries } from "../../../assessments/assessment-utils";
+import {fakeInitiative, fakeProgramme} from "../../change-initiative-utils";
+import {filterByAssessmentRating} from "../../../assessments/assessment-utils";
+import {nest} from "d3-collection";
+import {grey} from "../../../common/colors";
 
 const bindings = {
     parentEntityRef: "<",
@@ -67,19 +68,34 @@ const initialState = {
     },
     filterHelpText: "Select an assessment category to filter the change initiatives",
     gridOptions: {
-        columnDefs: [
-            { width: "15%", field: "kind", name: "Kind" },
-            mkRefCol("initiative"),
-            mkRefCol("programme"),
-            mkRefCol("project"),
-            { width: "25%", field: "name", name: "Name" },
-            { width: "15%", field: "lifecyclePhase", name: "Phase" }
-        ],
+        columnDefs: _.map(
+            [
+                { width: "15%", field: "kind", name: "Kind" },
+                mkRefCol("initiative"),
+                mkRefCol("programme"),
+                mkRefCol("project"),
+                { width: "25%", field: "name", name: "Name" },
+                { width: "15%", field: "lifecyclePhase", name: "Phase" }
+            ],
+            enrichWithInactiveStyling),
         data: []
     }
 };
 
 
+function calcCellClass(grid, row, col, rowRenderIndex, colRenderIndex) {
+    return row.entity.lifecyclePhase === "Retired"
+        ? "wcis-inactive-ci"
+        : "";
+}
+
+
+function enrichWithInactiveStyling(col) {
+    return Object.assign(
+        {},
+        col,
+        { cellClass: calcCellClass });}
+
 function determineHierarchy(cisById = {}, ci) {
     const none = null;
 
@@ -147,7 +163,67 @@ function mkTableData(changeInitiatives = [], lifecycleNamesByKey = {}) {
                 kind: changeKind
             }
         })
-        .orderBy(d => ["initiative.name", "programme.name", "project.name", "name"])
+        .orderBy(d => ["initiative.externalId", "programme.externalId", "project.externalId", "name"])
+        .value();
+}
+
+
+function mkAssessmentSummaries(definitions = [], schemeItems = [], ratings = [], total = 0) {
+    const indexedRatingSchemes = indexRatingSchemeItems(schemeItems);
+    const definitionsById = _.keyBy(definitions, d => d.id);
+
+    const nestedRatings = nest()
+        .key(d => d.assessmentDefinitionId)
+        .key(d => d.ratingId)
+        .rollup(xs => xs.length)
+        .entries(ratings);
+
+    return _
+        .chain(nestedRatings)
+        .map(d => {
+            const definition = definitionsById[Number(d.key)];
+            const assignedTotal = _.sumBy(d.values, v => v.value);
+            const values = _
+                .chain(d.values)
+                .map(v => {
+                    const propPath = [definition.ratingSchemeId, "ratingsById", v.key];
+                    const rating = _.get(indexedRatingSchemes, propPath);
+                    return Object.assign({}, v, { rating, count: v.value });
+                })
+                .concat([{
+                    key: "z",
+                    rating: {
+                        id: -1,
+                        name: "Not Provided",
+                        color: grey
+                    },
+                    count: _.max([0, total - assignedTotal])
+                }])
+                .filter(d => d.count > 0)
+                .value();
+
+            const extension = { definition, values };
+            return Object.assign({}, d , extension);
+        })
+        .orderBy(d => d.definition.name)
+        .value();
+}
+
+/**
+ * Given a flat list of rating schemes returns them indexed by their ids.  Also each scheme has
+ * an additional maps giving 'ratingsByCode' and 'ratingsById' .
+ * @param schemes
+ */
+function indexRatingSchemeItems(schemeItems = []) {
+    return _
+        .chain(schemeItems)
+        .groupBy(d => d.ratingSchemeId)
+        .map((v,k) => Object.assign({}, {
+            id: k,
+            ratingsByCode: _.keyBy(v, d => d.rating),
+            ratingsById: _.keyBy(v, d => d.id),
+        }))
+        .keyBy(d => d.id)
         .value();
 }
 
@@ -155,16 +231,8 @@ function mkTableData(changeInitiatives = [], lifecycleNamesByKey = {}) {
 function controller($q, serviceBroker) {
     const vm = initialiseData(this, initialState);
 
-    function init() {
-        const schemesPromise = serviceBroker
-            .loadAppData(CORE_API.RatingSchemeStore.findAll)
-            .then(r => vm.ratingSchemes = r.data);
-
-        const assessmentDefinitionsPromise = serviceBroker
-            .loadAppData(
-                CORE_API.AssessmentDefinitionStore.findByKind,
-                [ "CHANGE_INITIATIVE" ])
-            .then(r => vm.assessmentDefinitions = r.data);
+    vm.$onChanges = (changes) => {
+        const sameParent = isSameParentEntityRef(changes);
 
         const enumPromise = serviceBroker
             .loadAppData(CORE_API.EnumValueStore.findAll)
@@ -174,35 +242,25 @@ function controller($q, serviceBroker) {
                     "changeInitiativeLifecyclePhase");
             });
 
-        return $q
-            .all([schemesPromise, assessmentDefinitionsPromise, enumPromise]);
-    }
-
-
-    vm.$onChanges = (changes) => {
-        const sameParent = isSameParentEntityRef(changes);
-
         if (vm.parentEntityRef && !sameParent) {
-            const selectionOptions = mkSelectionOptions(vm.parentEntityRef);
-            const ciPromise = serviceBroker
-                .loadViewData(
-                    CORE_API.ChangeInitiativeStore.findHierarchyBySelector,
-                    [ selectionOptions ])
-                .then(r => vm.changeInitiatives = r.data);
-
-            const assessmentRatingsPromise = serviceBroker
+            const viewPromise = serviceBroker
                 .loadViewData(
-                    CORE_API.AssessmentRatingStore.findByTargetKindForRelatedSelector,
-                    [ "CHANGE_INITIATIVE", selectionOptions ])
-                .then(r => vm.assessmentRatings = r.data);
+                    CORE_API.ChangeInitiativeViewStore.findByEntity,
+                    [vm.parentEntityRef])
+                .then(r => {
+                    const d = r.data;
+                    vm.changeInitiatives = d.changeInitiatives;
+                    vm.assessmentRatings = d.ratings;
+                    vm.ratingSchemeItems = d.ratingSchemeItems;
+                    vm.assessmentDefinitions = d.assessmentDefinitions;
+                });
 
-            $q.all([init(), ciPromise, assessmentRatingsPromise])
+            $q.all([enumPromise, viewPromise])
                 .then(() => applyFilters());
         }
     };
 
     function applyFilters() {
-
         const retiredCiFilter =  vm.displayRetiredCis
             ? () => true
             : ci => ci.lifecyclePhase !== "RETIRED";
@@ -226,14 +284,13 @@ function controller($q, serviceBroker) {
 
         vm.assessmentSummaries = mkAssessmentSummaries(
             vm.assessmentDefinitions,
-            vm.ratingSchemes,
+            vm.ratingSchemeItems,
             inScopeRatings,
             inScopeCis.length);
 
         vm.gridOptions.data = mkTableData(
             relevantCis,
             vm.changeInitiativeLifecyclePhaseByKey);
-
     }
 
     vm.onSelectAssessmentRating = d => {
diff --git a/waltz-ng/client/change-initiative/index.js b/waltz-ng/client/change-initiative/index.js
index 4584a93c68..85556fea35 100644
--- a/waltz-ng/client/change-initiative/index.js
+++ b/waltz-ng/client/change-initiative/index.js
@@ -18,15 +18,16 @@
 
 import angular from "angular";
 
-import {registerComponents, registerStore} from "../common/module-utils";
+import {registerComponents, registerStores} from "../common/module-utils";
 
 import changeInitiativeStore from "./services/change-initiative-store";
+import changeInitiativeViewStore from "./services/change-initiative-view-store";
 import changeInitiativeSelector from "./directives/change-initiative-selector";
-import BulkChangeInitiativeSelector from "./components/bulk-change-initiative-selector/bulk-change-initiative-selector";
 
+import BulkChangeInitiativeSelector from "./components/bulk-change-initiative-selector/bulk-change-initiative-selector";
 import changeInitiativeSection from "./components/change-initiative-section/change-initiative-section";
-import changeInitiativeTree from "./components/tree/change-initiative-tree";
 
+import changeInitiativeTree from "./components/tree/change-initiative-tree";
 import Routes from "./routes";
 
 
@@ -35,11 +36,14 @@ function setup() {
     module
         .config(Routes);
 
-    registerStore(module, changeInitiativeStore);
+    registerStores(module, [
+        changeInitiativeStore,
+        changeInitiativeViewStore
+    ]);
 
     module
         .directive("waltzChangeInitiativeSelector", changeInitiativeSelector);
-        
+
     registerComponents(module, [
         changeInitiativeSection,
         changeInitiativeTree,
diff --git a/waltz-ng/client/change-initiative/services/change-initiative-view-store.js b/waltz-ng/client/change-initiative/services/change-initiative-view-store.js
new file mode 100644
index 0000000000..d0602da533
--- /dev/null
+++ b/waltz-ng/client/change-initiative/services/change-initiative-view-store.js
@@ -0,0 +1,57 @@
+/*
+ * Waltz - Enterprise Architecture
+ * Copyright (C) 2016, 2017, 2018, 2019 Waltz open source project
+ * See README.md for more information
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific
+ *
+ */
+import {checkIsEntityRef} from "../../common/checks";
+
+
+function store($http, BaseApiUrl) {
+
+    const BASE = `${BaseApiUrl}/change-initiative-view`;
+
+
+    const findByEntity = (ref) => {
+        checkIsEntityRef(ref);
+        return $http
+            .get(`${BASE}/entity/${ref.kind}/${ref.id}`, ref)
+            .then(r => r.data);
+    };
+
+
+    return {
+        findByEntity
+    };
+}
+
+store.$inject = ["$http", "BaseApiUrl"];
+
+
+const serviceName = "ChangeInitiativeViewStore";
+
+
+export const ChangeInitiativeViewStore_API = {
+    findByEntity: {
+        serviceName,
+        serviceFnName: "findByEntity",
+        description: "finds change initiatives by entity reference"
+    }
+};
+
+
+export default {
+    store,
+    serviceName
+};
\ No newline at end of file
diff --git a/waltz-ng/client/common/services/core-api-utils.js b/waltz-ng/client/common/services/core-api-utils.js
index f2e08deb89..bd6fc0642c 100644
--- a/waltz-ng/client/common/services/core-api-utils.js
+++ b/waltz-ng/client/common/services/core-api-utils.js
@@ -44,9 +44,8 @@ import {BookmarkStore_API as BookmarkStore} from "../../bookmarks/services/bookm
 import {
     BulkUploadLegalEntityRelationshipsStore_API as BulkUploadLegalEntityRelationshipsStore
 } from "../../legal-entity-relationship-kind/services/bulk-upload-legal-entity-relationships-store";
-import {
-    ChangeInitiativeStore_API as ChangeInitiativeStore
-} from "../../change-initiative/services/change-initiative-store";
+import {ChangeInitiativeStore_API as ChangeInitiativeStore} from "../../change-initiative/services/change-initiative-store";
+import {ChangeInitiativeViewStore_API as ChangeInitiativeViewStore} from "../../change-initiative/services/change-initiative-view-store";
 import {ChangeLogStore_API as ChangeLogStore} from "../../change-log/services/change-log-store";
 import {
     ChangeLogSummariesStore_API as ChangeLogSummariesStore
@@ -222,6 +221,7 @@ export const CORE_API = {
     BookmarkStore,
     BulkUploadLegalEntityRelationshipsStore,
     ChangeInitiativeStore,
+    ChangeInitiativeViewStore,
     ChangeLogStore,
     ChangeLogSummariesStore,
     ChangeSetStore,
diff --git a/waltz-service/src/main/java/org/finos/waltz/service/change_initiative/ChangeInitiativeViewService.java b/waltz-service/src/main/java/org/finos/waltz/service/change_initiative/ChangeInitiativeViewService.java
new file mode 100644
index 0000000000..186dd759c7
--- /dev/null
+++ b/waltz-service/src/main/java/org/finos/waltz/service/change_initiative/ChangeInitiativeViewService.java
@@ -0,0 +1,124 @@
+/*
+ * Waltz - Enterprise Architecture
+ * Copyright (C) 2016, 2017, 2018, 2019 Waltz open source project
+ * See README.md for more information
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific
+ *
+ */
+
+package org.finos.waltz.service.change_initiative;
+
+import org.finos.waltz.common.LoggingUtilities;
+import org.finos.waltz.data.GenericSelector;
+import org.finos.waltz.data.ImmutableGenericSelector;
+import org.finos.waltz.data.assessment_definition.AssessmentDefinitionDao;
+import org.finos.waltz.data.assessment_rating.AssessmentRatingDao;
+import org.finos.waltz.data.change_initiative.ChangeInitiativeDao;
+import org.finos.waltz.data.change_initiative.ChangeInitiativeIdSelectorFactory;
+import org.finos.waltz.data.entity_relationship.EntityRelationshipDao;
+import org.finos.waltz.data.rating_scheme.RatingSchemeDAO;
+import org.finos.waltz.model.EntityKind;
+import org.finos.waltz.model.EntityReference;
+import org.finos.waltz.model.assessment_definition.AssessmentDefinition;
+import org.finos.waltz.model.assessment_rating.AssessmentRating;
+import org.finos.waltz.model.change_initiative.ChangeInitiative;
+import org.finos.waltz.model.change_initiative.ChangeInitiativeView;
+import org.finos.waltz.model.change_initiative.ImmutableChangeInitiativeView;
+import org.finos.waltz.model.rating.RatingSchemeItem;
+import org.finos.waltz.schema.tables.EntityHierarchy;
+import org.finos.waltz.service.DIConfiguration;
+import org.jooq.Record1;
+import org.jooq.Select;
+import org.jooq.SelectOrderByStep;
+import org.jooq.impl.DSL;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.annotation.AnnotationConfigApplicationContext;
+import org.springframework.stereotype.Service;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Set;
+
+import static org.finos.waltz.common.Checks.checkNotNull;
+import static org.finos.waltz.common.SetUtilities.map;
+import static org.finos.waltz.model.EntityReference.mkRef;
+import static org.finos.waltz.model.IdSelectionOptions.mkOpts;
+import static org.finos.waltz.schema.Tables.RATING_SCHEME_ITEM;
+
+@Service
+public class ChangeInitiativeViewService {
+
+    private static final EntityHierarchy eh = EntityHierarchy.ENTITY_HIERARCHY;
+
+    private final ChangeInitiativeDao changeInitiativeDao;
+    private final EntityRelationshipDao relationshipDao;
+    private final AssessmentRatingDao assessmentRatingDao;
+    private final AssessmentDefinitionDao assessmentDefinitionDao;
+    private final RatingSchemeDAO ratingSchemeDao;
+
+    private final ChangeInitiativeIdSelectorFactory changeInitiativeIdSelectorFactory = new ChangeInitiativeIdSelectorFactory();
+
+    @Autowired
+    public ChangeInitiativeViewService(ChangeInitiativeDao changeInitiativeDao,
+                                       EntityRelationshipDao relationshipDao,
+                                       AssessmentRatingDao assessmentRatingDao, AssessmentDefinitionDao assessmentDefinitionDao, RatingSchemeDAO ratingSchemeDao)
+    {
+        checkNotNull(changeInitiativeDao, "changeInitiativeDao cannot be null");
+        checkNotNull(relationshipDao, "relationshipDao cannot be null");
+        checkNotNull(assessmentRatingDao, "assessmentRatingDao cannot be null");
+        checkNotNull(assessmentDefinitionDao, "assessmentDefinitionDao cannot be null");
+        checkNotNull(ratingSchemeDao, "ratingSchemeDao cannot be null");
+
+        this.changeInitiativeDao = changeInitiativeDao;
+        this.relationshipDao = relationshipDao;
+        this.assessmentRatingDao = assessmentRatingDao;
+        this.assessmentDefinitionDao = assessmentDefinitionDao;
+        this.ratingSchemeDao = ratingSchemeDao;
+    }
+
+
+    public ChangeInitiativeView findForEntityReference(EntityReference ref) {
+        Select<Record1<Long>> directCISelector = changeInitiativeIdSelectorFactory.apply(mkOpts(ref));
+
+        SelectOrderByStep<Record1<Long>> indirectCISelector = DSL
+                .select(eh.ID)
+                .from(eh)
+                .where(eh.KIND.eq(EntityKind.CHANGE_INITIATIVE.name())
+                    .and(eh.ANCESTOR_ID.in(directCISelector)))
+                .union(DSL
+                    .select(eh.ANCESTOR_ID)
+                    .from(eh)
+                    .where(eh.KIND.eq(EntityKind.CHANGE_INITIATIVE.name())
+                            .and(eh.ID.in(directCISelector))));
+
+        GenericSelector indirectGenericCISelector = ImmutableGenericSelector
+                .builder()
+                .selector(indirectCISelector)
+                .kind(EntityKind.CHANGE_INITIATIVE).build();
+
+        Collection<ChangeInitiative> cis = changeInitiativeDao.findForSelector(indirectCISelector);
+        List<AssessmentRating> ratings = assessmentRatingDao.findByGenericSelector(indirectGenericCISelector);
+        Set<AssessmentDefinition> defs = assessmentDefinitionDao.findByEntityKind(EntityKind.CHANGE_INITIATIVE);
+        List<RatingSchemeItem> ratingSchemeItems = ratingSchemeDao.fetchItems(RATING_SCHEME_ITEM.SCHEME_ID.in(map(
+                defs,
+                AssessmentDefinition::ratingSchemeId)));
+
+        return ImmutableChangeInitiativeView.builder()
+                .changeInitiatives(cis)
+                .ratings(ratings)
+                .ratingSchemeItems(ratingSchemeItems)
+                .assessmentDefinitions(defs)
+                .build();
+    }
+
+}
diff --git a/waltz-web/src/main/java/org/finos/waltz/web/endpoints/api/ChangeInitiativeViewEndpoint.java b/waltz-web/src/main/java/org/finos/waltz/web/endpoints/api/ChangeInitiativeViewEndpoint.java
new file mode 100644
index 0000000000..3fe072b1fc
--- /dev/null
+++ b/waltz-web/src/main/java/org/finos/waltz/web/endpoints/api/ChangeInitiativeViewEndpoint.java
@@ -0,0 +1,60 @@
+/*
+ * Waltz - Enterprise Architecture
+ * Copyright (C) 2016, 2017, 2018, 2019 Waltz open source project
+ * See README.md for more information
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific
+ *
+ */
+
+package org.finos.waltz.web.endpoints.api;
+
+
+import org.finos.waltz.model.change_initiative.ChangeInitiativeView;
+import org.finos.waltz.service.change_initiative.ChangeInitiativeViewService;
+import org.finos.waltz.web.DatumRoute;
+import org.finos.waltz.web.WebUtilities;
+import org.finos.waltz.web.endpoints.Endpoint;
+import org.finos.waltz.web.endpoints.EndpointUtilities;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+
+import static org.finos.waltz.common.Checks.checkNotNull;
+import static org.finos.waltz.web.WebUtilities.getEntityReference;
+
+
+@Service
+public class ChangeInitiativeViewEndpoint implements Endpoint {
+
+    private static final String BASE_URL = WebUtilities.mkPath("api", "change-initiative-view");
+
+    private final ChangeInitiativeViewService service;
+
+    @Autowired
+    public ChangeInitiativeViewEndpoint(ChangeInitiativeViewService service) {
+        checkNotNull(service, "service cannot be null");
+
+        this.service = service;
+    }
+
+
+    @Override
+    public void register() {
+        String findByRefPath = WebUtilities.mkPath(BASE_URL, "entity", ":kind", ":id");
+
+        DatumRoute<ChangeInitiativeView> findByRefRoute = (req, resp) -> service.findForEntityReference(
+                getEntityReference(req));
+
+        EndpointUtilities.getForDatum(findByRefPath, findByRefRoute);
+    }
+
+}

From 3d3821e0e605b42ae253f497a1ed2beb96de11ac Mon Sep 17 00:00:00 2001
From: David Watkins <davidwatkins73@gmail.com>
Date: Thu, 27 Jul 2023 21:28:48 +0100
Subject: [PATCH 2/2] Change Initiatives: incomplete assessments filters

#6687
---
 .../change_initiative/ChangeInitiativeViewService.java       | 5 +----
 .../web/endpoints/api/ChangeInitiativeViewEndpoint.java      | 2 +-
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/waltz-service/src/main/java/org/finos/waltz/service/change_initiative/ChangeInitiativeViewService.java b/waltz-service/src/main/java/org/finos/waltz/service/change_initiative/ChangeInitiativeViewService.java
index 186dd759c7..a403c5ba98 100644
--- a/waltz-service/src/main/java/org/finos/waltz/service/change_initiative/ChangeInitiativeViewService.java
+++ b/waltz-service/src/main/java/org/finos/waltz/service/change_initiative/ChangeInitiativeViewService.java
@@ -18,7 +18,6 @@
 
 package org.finos.waltz.service.change_initiative;
 
-import org.finos.waltz.common.LoggingUtilities;
 import org.finos.waltz.data.GenericSelector;
 import org.finos.waltz.data.ImmutableGenericSelector;
 import org.finos.waltz.data.assessment_definition.AssessmentDefinitionDao;
@@ -36,13 +35,11 @@
 import org.finos.waltz.model.change_initiative.ImmutableChangeInitiativeView;
 import org.finos.waltz.model.rating.RatingSchemeItem;
 import org.finos.waltz.schema.tables.EntityHierarchy;
-import org.finos.waltz.service.DIConfiguration;
 import org.jooq.Record1;
 import org.jooq.Select;
 import org.jooq.SelectOrderByStep;
 import org.jooq.impl.DSL;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.context.annotation.AnnotationConfigApplicationContext;
 import org.springframework.stereotype.Service;
 
 import java.util.Collection;
@@ -87,7 +84,7 @@ public ChangeInitiativeViewService(ChangeInitiativeDao changeInitiativeDao,
     }
 
 
-    public ChangeInitiativeView findForEntityReference(EntityReference ref) {
+    public ChangeInitiativeView getForEntityReference(EntityReference ref) {
         Select<Record1<Long>> directCISelector = changeInitiativeIdSelectorFactory.apply(mkOpts(ref));
 
         SelectOrderByStep<Record1<Long>> indirectCISelector = DSL
diff --git a/waltz-web/src/main/java/org/finos/waltz/web/endpoints/api/ChangeInitiativeViewEndpoint.java b/waltz-web/src/main/java/org/finos/waltz/web/endpoints/api/ChangeInitiativeViewEndpoint.java
index 3fe072b1fc..084665839c 100644
--- a/waltz-web/src/main/java/org/finos/waltz/web/endpoints/api/ChangeInitiativeViewEndpoint.java
+++ b/waltz-web/src/main/java/org/finos/waltz/web/endpoints/api/ChangeInitiativeViewEndpoint.java
@@ -51,7 +51,7 @@ public ChangeInitiativeViewEndpoint(ChangeInitiativeViewService service) {
     public void register() {
         String findByRefPath = WebUtilities.mkPath(BASE_URL, "entity", ":kind", ":id");
 
-        DatumRoute<ChangeInitiativeView> findByRefRoute = (req, resp) -> service.findForEntityReference(
+        DatumRoute<ChangeInitiativeView> findByRefRoute = (req, resp) -> service.getForEntityReference(
                 getEntityReference(req));
 
         EndpointUtilities.getForDatum(findByRefPath, findByRefRoute);