Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDC3 for Web Browsers Discussion group 21st Nov 2024 #1443

Closed
6 of 7 tasks
kriswest opened this issue Nov 20, 2024 · 8 comments
Closed
6 of 7 tasks

FDC3 for Web Browsers Discussion group 21st Nov 2024 #1443

kriswest opened this issue Nov 20, 2024 · 8 comments
Labels

Comments

@kriswest
Copy link
Contributor

kriswest commented Nov 20, 2024

Group overview

Group convened to work on proposals to enable FDC3 use in a web browser, without the use of a browser extension.

The main proposal is now part of the current draft of FDC3 2.2 on the mina branch of the FDC3 repo and website (main/unreleased version), see:

Open Pull Requests:

Relevant issue tags

Current open issues that relate to the above concepts with the label:
image

Meeting Date

Thursday 21st November 2024 - 11am (US eastern timezone EST) / 4pm (London, GMT)

Zoom info

  • Join Zoom Meeting
  • Meeting ID: 969 4029 4948
  • Passcode: 636931
  • Dial-in:
    Country International Dial-in Toll-free Dial-in
    US +1 929 205 6099 (New York) 877 853 5247
    UK +44 330 088 5830 0800 031 5717
    France +33 1 8699 5831 0 800 940 415
    Find your local number https://zoom.us/u/ad2WVnBzb8

Meeting notices

  • FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

  • All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

  • FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact [email protected] with any questions.

  • FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

  • A Discussion Group has no direct decision-making power regarding the FDC3 standard - rather it is intended that anything they propose or work on will result in proposals (via Github issues and PRs) for the Standards Working Group participants to consider and vote on for inclusion in the standard.

Participation Requirements

Note: Meeting participants are expected to accept the terms of the FDC3 license (Community Specification License), understand the governance process and have a CLA in place.

Please click the following links at the start of the meeting if you have not done so previously.

Tracking Attendance

Note: Meeting participants are expected to add a comment to this GitHub issue in order that we can track attendance of FDC3 project meetings. Please do this at the start of the meeting.

Agenda

Minutes

  • Session Storage proposal (Updating SessionStorage data format to additionally scope data #1442) was reviewed.
    • The proposal was accepted by the meeting, subject further review for clarity.
    • A deep link was added to simplify review.
  • Recent activity and merged PRs were reviewed with attendees and the current status of the implementation project discussed.
    • @kriswest stated that: the FDC3 community will ultimately have to take ownership of the additions to the codebase to support getAgent. Up until now @robmoffat has carried the implementation project. We only get his support (shared with other projects) as FDC3 is strategic initiative this year.
    • @robmoffat It is likely that FINOS will have different priorities next year which may not include FDC3 as a startegic initiative again. @kriswest Hence, it is doubly important that the community take over maintenance and onward development.
    • @kriswest: I'm currently working in the project to:
      • improve the use of typing (replacing type overrides and the use of any),
      • align the implementation with the connection flow in the documentation, and
      • improve the separation between the WCP and DACP implementations.
    • @robmoffat Content has been added to the top-level README file in the fdc3-for-web-impl branch to describe the new layout of the repository and to help developers working on it get started.
    • @robmoffat also a number of issues have been created to track implementation tasks, see: https://github.com/finos/FDC3/issues?q=is%3Aopen+is%3Aissue+milestone%3A2.2+label%3A%22FDC3+for+Web+Browsers%22
  • AOB
    • @Roaders' TSMorph PRs were discussed: They post-process the generated schemas and produce:
      • Unions of the different message types by type (RequestMessage, ResponseMessage, EventMessage), which enables better typing in code based on them: Use TS Morph to generate type predicates #1387 (comment)
      • TypeGuard predicates (e.g. isContextListenerUnsubscribeRequest) that again help with typing.
    • An updated version was just raised as Modify generate-type-predicates to only include interfaces that have … #1444 based on previous feedback
      • Some duplicated generated code was identified during the meeting, to be corrected
      • @robmoffat had already merged the PR into fdc3-for-web-impl and started using the generated code, adding in a set of constants for message type names.
        • The constants were discussed and (perhaps) considered to be duplicating the types...
      • The performance of the type guards was discussed - they currently involve stringifying messages and then reparsing them using the quicktype generated convert functions, which validate against the schemas. This is potentially costly - but we are unsure as to how costly.
      • An alternative faster implementation would be to just check the type name without validating content - there are merits to both approaches.
        • It was resolved to create fast is* functions and rename the existing ones (that perform validation) to isValid*
    • @kriswest recommended that we replace the quicktype generated AppRequestMessage, AgentResponseMessage and AgentEventMessage with the unions as they simply do a better job of typig the same objects.

Action Items

Untracked attendees

Full name Affiliation GitHub username
@paulgoldsmith
Copy link

Paul Goldsmith / Morgan Stanley

@Davidhanson90
Copy link

David Hanson / Morgan Stanley 🚀

@Roaders
Copy link
Contributor

Roaders commented Nov 21, 2024

Giles Roadnight / Morgan Stanley

@robmoffat
Copy link
Member

Rob mOfFaT / fINoS

@pvoznyuk
Copy link

Pavlo Vozniuk @ RBC CM

@watson-ew
Copy link

Chris Watson / Elgin White 👋

@novavi
Copy link

novavi commented Nov 21, 2024

Derek Novavi / S&P Global

@VedPrakashJha-FMR
Copy link

Ved Jha / Fidelity Investments

@kriswest kriswest changed the title FDC3 for Web Browsers Discussion group FDC3 for Web Browsers Discussion group 21st Nov 2024 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants