Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RunDetection: Complete Implementation for nexus configured MARI runs. #71

Open
keiranjprice101 opened this issue Mar 31, 2023 · 0 comments
Open

RunDetection: Complete Implementation for nexus configured MARI runs. #71

keiranjprice101 opened this issue Mar 31, 2023 · 0 comments
Assignees
@keiranjprice101

Comments

@keiranjprice101
Copy link
Collaborator

Description of the issue

Confirm with Duc the remaining data values for the MARI stich rule.

Things to be Confirmed:

  • ei values for summed runs
  • will they actually include the remove_bkg as False
  • Will the sam_rmm, sam_mass ever be included for summed runs
  • Anything else to know?
  • To simplify the mari script, could ei always be List[float] | 'auto' instead even for single runs instead of also including float for a single ei.
  • Any info on the types if they are included in the nexus file. (e.g. an int in a nexus file is extracted as i32, etc.)

Based on this meeting update MariStitchRule and implement a summed runs e2e test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keiranjprice101 keiranjprice101

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keiranjprice101