-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volume doesn't use RetroFW's volume #171
Comments
Sure, I'll take a look
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Jared Reich ***@***.***>
Sent: Wednesday, July 7, 2021 5:08:24 PM
To: fgl82/simplemenu ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [fgl82/simplemenu] Volume doesn't use RetroFW's volume (#171)
Hey! Quick question, I noticed that on some devices, like the RG-300, the volume wheel is very hard to adjust on lower volume settings, so I set the "Audio volume" to 1 in the RetroFW settings, which fixes the issue when loading an emulator from the RetroFW interface. But if I go into SimpleMenu and start up a game, the volume is back to 100. Might this be because of these lines: https://github.com/fgl82/simplemenu/blob/27d95ee78da3c8323aa208e9f96ae77cacddd1d7/simplemenu/src/logic/system_logic_rfw.c#L94-L96
Is there any way we can make SimpleMenu inherit the "Audio volume" setting from RetroFW rather than forcing it to 100%?
Thanks very much for reading!!!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#171>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABN2JHHEHG6KAARW2464D2LTWSX3RANCNFSM477KYWRQ>.
|
You are so kind and responsive! Please let me know if you need help, I am also a developer but sadly not with the C language 😛 |
No problem, I'll change that and run some tests. I totally took that code from gmenu and never questioned it, as I usually play with headphones (through which the base volume is not bad at all) or in an environment where the base volume is not too loud for me.
I don't like the menu messing with OS settings, so I'll try removing that and see how it works.
|
Very cool, thanks for your time in replying and trying this. I also hope you don't mind me bombarding your issues page with specific nitpicky stuff. My son and I are sooo enjoying SimpleMenu on our RG-300's and are just noticing these couple things. Cheers!!! |
Haven't fixed this on the latest release (9.3), since it seems RFW initializes volume in 0, forcing me to define "something" or it won't have sound at all. |
Thanks so much for the follow up. That sounds like a great solution, really looking forward to using it!! |
You've been doing awesome with simplemenu release lately man, great work! So excited for this volume config feature if you're able to find the solution. I think it's the last final piece to perfect the RG-300 device for me! Cheers man! 🍻 |
I'll tackle that for the next version
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Jared Reich ***@***.***>
Sent: Monday, September 13, 2021 3:11:19 PM
To: fgl82/simplemenu ***@***.***>
Cc: FGL82 ***@***.***>; Comment ***@***.***>
Subject: Re: [fgl82/simplemenu] Volume doesn't use RetroFW's volume (#171)
You've been doing awesome with simplemenu release lately man, great work! So excited for this volume config feature if you're able to find the solution. I think it's the last final piece to perfect the RG-300 device for me!
Cheers man! 🍻
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#171 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABN2JHB24ZTO43BW6QFAOKLUBY5EPANCNFSM477KYWRQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sir, you are wonderful. |
Sorry, this is still pending, still planning to work on it eventually. |
No need to apologize. Thank you very much for the follow up response. Looking forward to it! Cheers!!! |
@jaredreich I have modified SimpleMenu to add the ability to change the volume on RG300 (new option for SimpleMenu on Settings Screen). |
Hey! Quick question, I noticed that on some devices, like the RG-300, the volume wheel is very hard to adjust on lower volume settings, so I set the "Audio volume" to
1
in the RetroFW settings, which fixes the issue when loading an emulator from the RetroFW interface. But if I go into SimpleMenu and start up a game, the volume is back to100
. Might this be because of these lines:simplemenu/simplemenu/src/logic/system_logic_rfw.c
Lines 94 to 96 in 27d95ee
Is there any way we can make SimpleMenu inherit the "Audio volume" setting from RetroFW rather than forcing it to 100%?
Thanks very much for reading!!!
The text was updated successfully, but these errors were encountered: