Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D/ST populating as "3" #440

Closed
chadallison opened this issue Nov 1, 2024 · 2 comments · Fixed by #441
Closed

D/ST populating as "3" #440

chadallison opened this issue Nov 1, 2024 · 2 comments · Fixed by #441

Comments

@chadallison
Copy link

Describe the bug
Very minor issue, it would be a stretch to even call it an issue. Seeing that D/ST is populating as the number 3 for me.

Reprex

league_conn = ff_connect(platform = "espn", league_id = "81518506", season = 2024)

ff_playerscores(league_conn) |>
  filter(franchise_name != 0 & str_detect(player_name, "D/ST"))

Expected behavior
I would expect the pos variable here to have the values "D/ST" but instead I'm seeing "3" and they seem to be populating correctly for all other positions.

Session information
Please copy the output of ffscrapr::ffverse_sitrep() into the box below.

You've asked for the packages ffsimulator, ffpros, and ffopportunity which are not installed. 
They are skipped.
── System Info ─────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.3.1 (2023-06-16 ucrt)   • Running under: Windows 11 x64 (build 22631)
── ffverse Packages ────────────────────────────────────────────────────────────────────────────────────────────
• ffscrapr (1.4.8.19)
── ffverse Options ─────────────────────────────────────────────────────────────────────────────────────────────
No options set for ffscrapr
── ffverse Dependencies ────────────────────────────────────────────────────────────────────────────────────────
• askpass    (1.2.1)   • glue      (1.6.2)  • rappdirs   (0.3.3)   
• assertthat (0.2.1)   • httr      (1.4.7)  • ratelimitr (0.4.1)   
• backports  (1.4.1)   • jsonlite  (1.8.8)  • rlang      (1.1.1)   
• cachem     (1.0.8)   • lifecycle (1.0.4)  • stringi    (1.7.12)  
• checkmate  (2.3.2)   • magrittr  (2.0.3)  • stringr    (1.5.0)   
• cli        (3.6.1)   • memoise   (2.0.1)  • sys        (3.4.3)   
• cpp11      (0.5.0)   • mime      (0.12)   • tibble     (3.2.1)   
• curl       (5.2.1)   • nflreadr  (1.3.2)  • tidyr      (1.3.0)   
• data.table (1.14.8)  • openssl   (2.2.2)  • tidyselect (1.2.1)   
• dplyr      (1.1.2)   • pillar    (1.9.0)  • utf8       (1.2.3)   
• fansi      (1.0.4)   • pkgconfig (2.0.3)  • vctrs      (0.6.3)   
• fastmap    (1.1.1)   • purrr     (1.0.1)  • withr      (3.0.1)   
• generics   (0.1.3)   • R6        (2.5.1)    
────────────────────────────────────────────────────────────────────────────────────────────────────────────────
@tanho63
Copy link
Member

tanho63 commented Nov 1, 2024

Give it a go from new main branch

@tanho63 tanho63 reopened this Nov 1, 2024
@chadallison
Copy link
Author

Working now! Thanks Tan, helpful as always!

@tanho63 tanho63 closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants