no daemonize but pidfile specified?

[mrbrdo]

I noticed you bother to specify a pid file, but daemonize is set to no. Why is that?

The real reason I ask is because I wanted to use monit for my redis, but there is no pidfile, since daemonize is set to no, and there is no setting in this cookbook to change that. I see now that runit already does monitoring, but I still don't see why you bother with the pidfile path, since it's not used.

[nukemberg]

i'm using redis primarily with runit which requires service processes to run in the foreground. pidfile has been left in case some version of redis requires it.

[mrbrdo]

Imo it's a bit confusing, it took me a while to figure out what was going on because of that pidfile config. If nothing else it would be worth at least adding a comment about that, although I doubt a newer version of redis will ever require the pidfile setting when it's not daemonized.

[nukemberg]

you raise excellent points.

On Thu, Feb 5, 2015 at 7:11 PM, Jan Berdajs [email protected]
wrote:

Imo it's a bit confusing, it took me a while to figure out what was going
on because of that pidfile config. If nothing else it would be worth at
least adding a comment about that, although I doubt a newer version of
redis will ever require the pidfile setting when it's not daemonized.

—
Reply to this email directly or view it on GitHub
#8 (comment)
.