From fecf765fd5b0f354b5c4e1bdd9f1815f052bba6e Mon Sep 17 00:00:00 2001 From: armandobelardo Date: Tue, 17 Sep 2024 13:27:57 -0400 Subject: [PATCH] cr --- fern/apis/fdr/definition/generators/cli.yml | 19 +------------------ .../fdr/definition/generators/commons.yml | 7 ++++--- .../generators/resources/cli/client/Client.ts | 2 +- .../resources/cli/types/BaseCliRelease.ts | 4 +--- .../resources/cli/types/CliReleaseTag.ts | 7 ------- .../resources/cli/types/CliReleaseTagEnum.ts | 12 ------------ .../generators/resources/cli/types/index.ts | 2 -- .../resources/commons/types/ChangelogEntry.ts | 5 +++-- .../resources/versions/client/Client.ts | 2 +- .../resources/cli/types/BaseCliRelease.d.ts | 3 +-- .../resources/cli/types/CliReleaseTag.d.ts | 5 ----- .../resources/cli/types/CliReleaseTag.js | 4 ---- .../cli/types/CliReleaseTagEnum.d.ts | 10 ---------- .../resources/cli/types/CliReleaseTagEnum.js | 9 --------- .../generators/resources/cli/types/index.d.ts | 2 -- .../generators/resources/cli/types/index.js | 2 -- .../commons/types/ChangelogEntry.d.ts | 5 +++-- 17 files changed, 15 insertions(+), 85 deletions(-) delete mode 100644 packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/CliReleaseTag.ts delete mode 100644 packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/CliReleaseTagEnum.ts delete mode 100644 servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTag.d.ts delete mode 100644 servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTag.js delete mode 100644 servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTagEnum.d.ts delete mode 100644 servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTagEnum.js diff --git a/fern/apis/fdr/definition/generators/cli.yml b/fern/apis/fdr/definition/generators/cli.yml index 982172ef48..c6a9d9dfb8 100644 --- a/fern/apis/fdr/definition/generators/cli.yml +++ b/fern/apis/fdr/definition/generators/cli.yml @@ -6,30 +6,13 @@ imports: commons: ./commons.yml types: - CliReleaseTagEnum: - enum: - - name: fern_definition - value: "Fern Definition" - - name: openapi - value: "OpenAPI" - - name: asyncapi - value: "AsyncAPI" - - name: grpc - value: "gRPC" - - CliReleaseTag: - discriminated: false - union: - - string - - CliReleaseTagEnum - BaseCliRelease: properties: irVersion: type: integer docs: The major version of the IR that this CLI exposes. tags: - type: optional> + type: optional> docs: Tags to categorize the CLI release. CliReleaseRequest: diff --git a/fern/apis/fdr/definition/generators/commons.yml b/fern/apis/fdr/definition/generators/commons.yml index 0c55f747b9..d506b3cfef 100644 --- a/fern/apis/fdr/definition/generators/commons.yml +++ b/fern/apis/fdr/definition/generators/commons.yml @@ -43,10 +43,11 @@ types: properties: type: ChangelogEntryType summary: string - pullRequestUrl: - type: optional + links: + type: optional> docs: | - The URL to the pull request that introduced this change. This is optional for backcompat. + Any URLs that are relevant to the change, such as a PR or issue. This is optional for backcompat. + You do not always need to specify the URL as the CLI can fill it in with the current PR, but given you can choose to not release within the same PR as the change is introduced, this should be specified for divorcing the two. upgradeNotes: optional diff --git a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/client/Client.ts b/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/client/Client.ts index 8f7b310096..ce3630e5ef 100644 --- a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/client/Client.ts +++ b/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/client/Client.ts @@ -209,7 +209,7 @@ export class Cli { * changelogEntry: [{ * type: FernRegistry.generators.ChangelogEntryType.Fix, * summary: "string", - * pullRequestUrl: { + * links: { * "key": "value" * }, * upgradeNotes: { diff --git a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/BaseCliRelease.ts b/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/BaseCliRelease.ts index d4f2de9c3a..2516e51ab5 100644 --- a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/BaseCliRelease.ts +++ b/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/BaseCliRelease.ts @@ -2,11 +2,9 @@ * This file was auto-generated by Fern from our API Definition. */ -import * as FernRegistry from "../../../../../index"; - export interface BaseCliRelease { /** The major version of the IR that this CLI exposes. */ irVersion: number; /** Tags to categorize the CLI release. */ - tags?: FernRegistry.generators.CliReleaseTag[]; + tags?: string[]; } diff --git a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/CliReleaseTag.ts b/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/CliReleaseTag.ts deleted file mode 100644 index 3e1dda44fc..0000000000 --- a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/CliReleaseTag.ts +++ /dev/null @@ -1,7 +0,0 @@ -/** - * This file was auto-generated by Fern from our API Definition. - */ - -import * as FernRegistry from "../../../../../index"; - -export type CliReleaseTag = string | FernRegistry.generators.CliReleaseTagEnum; diff --git a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/CliReleaseTagEnum.ts b/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/CliReleaseTagEnum.ts deleted file mode 100644 index 190c08ee54..0000000000 --- a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/CliReleaseTagEnum.ts +++ /dev/null @@ -1,12 +0,0 @@ -/** - * This file was auto-generated by Fern from our API Definition. - */ - -export type CliReleaseTagEnum = "Fern Definition" | "OpenAPI" | "AsyncAPI" | "gRPC"; - -export const CliReleaseTagEnum = { - FernDefinition: "Fern Definition", - Openapi: "OpenAPI", - Asyncapi: "AsyncAPI", - Grpc: "gRPC", -} as const; diff --git a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/index.ts b/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/index.ts index 2e5dac7ca6..5d1c5626dc 100644 --- a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/index.ts +++ b/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/cli/types/index.ts @@ -1,5 +1,3 @@ -export * from "./CliReleaseTagEnum"; -export * from "./CliReleaseTag"; export * from "./BaseCliRelease"; export * from "./CliReleaseRequest"; export * from "./CliRelease"; diff --git a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/commons/types/ChangelogEntry.ts b/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/commons/types/ChangelogEntry.ts index 72b5f15e7d..942f2f0baf 100644 --- a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/commons/types/ChangelogEntry.ts +++ b/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/commons/types/ChangelogEntry.ts @@ -11,11 +11,12 @@ export interface ChangelogEntry { type: FernRegistry.generators.ChangelogEntryType; summary: string; /** - * The URL to the pull request that introduced this change. This is optional for backcompat. + * Any URLs that are relevant to the change, such as a PR or issue. This is optional for backcompat. + * * You do not always need to specify the URL as the CLI can fill it in with the current PR, but given you can choose to not * release within the same PR as the change is introduced, this should be specified for divorcing the two. */ - pullRequestUrl?: string; + links?: string[]; upgradeNotes?: string; added?: string[]; changed?: string[]; diff --git a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/versions/client/Client.ts b/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/versions/client/Client.ts index 56f807074e..ad51a0541c 100644 --- a/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/versions/client/Client.ts +++ b/packages/fdr-sdk/src/client/generated/api/resources/generators/resources/versions/client/Client.ts @@ -167,7 +167,7 @@ export class Versions { * changelogEntry: [{ * type: FernRegistry.generators.ChangelogEntryType.Fix, * summary: "string", - * pullRequestUrl: { + * links: { * "key": "value" * }, * upgradeNotes: { diff --git a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/BaseCliRelease.d.ts b/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/BaseCliRelease.d.ts index 74bde1bcaf..ce087e1a01 100644 --- a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/BaseCliRelease.d.ts +++ b/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/BaseCliRelease.d.ts @@ -1,10 +1,9 @@ /** * This file was auto-generated by Fern from our API Definition. */ -import * as FernRegistry from "../../../../../index"; export interface BaseCliRelease { /** The major version of the IR that this CLI exposes. */ irVersion: number; /** Tags to categorize the CLI release. */ - tags?: FernRegistry.generators.CliReleaseTag[]; + tags?: string[]; } diff --git a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTag.d.ts b/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTag.d.ts deleted file mode 100644 index 40987f435c..0000000000 --- a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTag.d.ts +++ /dev/null @@ -1,5 +0,0 @@ -/** - * This file was auto-generated by Fern from our API Definition. - */ -import * as FernRegistry from "../../../../../index"; -export declare type CliReleaseTag = string | FernRegistry.generators.CliReleaseTagEnum; diff --git a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTag.js b/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTag.js deleted file mode 100644 index 0b46289f5b..0000000000 --- a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTag.js +++ /dev/null @@ -1,4 +0,0 @@ -/** - * This file was auto-generated by Fern from our API Definition. - */ -export {}; diff --git a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTagEnum.d.ts b/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTagEnum.d.ts deleted file mode 100644 index 6d3230fb78..0000000000 --- a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTagEnum.d.ts +++ /dev/null @@ -1,10 +0,0 @@ -/** - * This file was auto-generated by Fern from our API Definition. - */ -export declare type CliReleaseTagEnum = "Fern Definition" | "OpenAPI" | "AsyncAPI" | "gRPC"; -export declare const CliReleaseTagEnum: { - readonly FernDefinition: "Fern Definition"; - readonly Openapi: "OpenAPI"; - readonly Asyncapi: "AsyncAPI"; - readonly Grpc: "gRPC"; -}; diff --git a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTagEnum.js b/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTagEnum.js deleted file mode 100644 index 199ab12db2..0000000000 --- a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/CliReleaseTagEnum.js +++ /dev/null @@ -1,9 +0,0 @@ -/** - * This file was auto-generated by Fern from our API Definition. - */ -export const CliReleaseTagEnum = { - FernDefinition: "Fern Definition", - Openapi: "OpenAPI", - Asyncapi: "AsyncAPI", - Grpc: "gRPC", -}; diff --git a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/index.d.ts b/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/index.d.ts index 2e5dac7ca6..5d1c5626dc 100644 --- a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/index.d.ts +++ b/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/index.d.ts @@ -1,5 +1,3 @@ -export * from "./CliReleaseTagEnum"; -export * from "./CliReleaseTag"; export * from "./BaseCliRelease"; export * from "./CliReleaseRequest"; export * from "./CliRelease"; diff --git a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/index.js b/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/index.js index 2e5dac7ca6..5d1c5626dc 100644 --- a/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/index.js +++ b/servers/fdr/src/api/generated/api/resources/generators/resources/cli/types/index.js @@ -1,5 +1,3 @@ -export * from "./CliReleaseTagEnum"; -export * from "./CliReleaseTag"; export * from "./BaseCliRelease"; export * from "./CliReleaseRequest"; export * from "./CliRelease"; diff --git a/servers/fdr/src/api/generated/api/resources/generators/resources/commons/types/ChangelogEntry.d.ts b/servers/fdr/src/api/generated/api/resources/generators/resources/commons/types/ChangelogEntry.d.ts index e48490b9f3..ea4e93a33e 100644 --- a/servers/fdr/src/api/generated/api/resources/generators/resources/commons/types/ChangelogEntry.d.ts +++ b/servers/fdr/src/api/generated/api/resources/generators/resources/commons/types/ChangelogEntry.d.ts @@ -9,11 +9,12 @@ export interface ChangelogEntry { type: FernRegistry.generators.ChangelogEntryType; summary: string; /** - * The URL to the pull request that introduced this change. This is optional for backcompat. + * Any URLs that are relevant to the change, such as a PR or issue. This is optional for backcompat. + * * You do not always need to specify the URL as the CLI can fill it in with the current PR, but given you can choose to not * release within the same PR as the change is introduced, this should be specified for divorcing the two. */ - pullRequestUrl?: string; + links?: string[]; upgradeNotes?: string; added?: string[]; changed?: string[];