Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to declaration multiple workspaces #664

Closed
jasonbronson opened this issue Aug 2, 2018 · 3 comments
Closed

Jump to declaration multiple workspaces #664

jasonbronson opened this issue Aug 2, 2018 · 3 comments

Comments

@jasonbronson
Copy link

Jump to declaration goes to incorrect files in another folder in workspace when using multiple files with same file and method names.

VSCode Version: 1.25.1
OS Version: 10.13.6 OSX
Steps to Reproduce:

While setting this up for you I realized you don't even need a workspace for this issue. Just two folders does the trick.

Step 1 create a folder vscodebug
Step 2 open in vscode the folder with my github repo in it
https://github.com/jasonbronson/BugVSCode
Step 3 open up posts.php under this folder in editor
/pcentral/wp-content/themes/theme1/libraries/posts.php
Step 4 close the posts.php file
Step 5 open up pressreleases.php file under
/pmasters/wp-content/themes/theme2/libraries/pressreleases.php
Step 6 Highlight "Posts" under Pressrelease extends Posts
Step 7 hit go to declaration
Step 8 notice it jumps to the top folder with that file.

I believe if you're in a folder the top level would be all that it should be searching for not going to other folders.
Example I open up top folder 1 to copy some code into the library file I'm building into folder2 now this bug occurs.

@Ciantic
Copy link

Ciantic commented Oct 9, 2018

This probably does not have a support for multiple folders yet. Quote from workspace support in VSCode:

If you are implementing a language server then you are affected since up to now a language server only had to handle a single folder. In the new multi-folder setup, a language server should be able to handle multiple folders. See the section 'Language Client/Language Server' below.

So the language server must have a possibility to index multiple arbitrary folders, and make them work as one.

@Ciantic
Copy link

Ciantic commented Nov 11, 2018

This is duplicate of #513

@felixfbecker
Copy link
Owner

@Ciantic thanks! Duplicate of #513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants