Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test testPastVotes is failing #69

Open
kphed opened this issue Nov 2, 2023 · 1 comment
Open

Test testPastVotes is failing #69

kphed opened this issue Nov 2, 2023 · 1 comment

Comments

@kphed
Copy link
Contributor

kphed commented Nov 2, 2023

The test fails because the starting block.number is 1, causing this assertion to fail: https://github.com/fei-protocol/flywheel-v2/blob/main/src/test/token/ERC20MultiVotes.t.sol#L247.

        hevm.roll(1);
        uint256 block2 = block.number;
        require(block2 == block1 + 1);

hevm.roll sets the block number to 1 and the required condition (block2 == block1 + 1) is unmet.

@kphed
Copy link
Contributor Author

kphed commented Nov 6, 2023

Updated the original description to be clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant