Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusion between HostCountry and HostCountryAllowed in the UI #374

Open
abompard opened this issue Aug 19, 2024 · 2 comments
Open

Confusion between HostCountry and HostCountryAllowed in the UI #374

abompard opened this issue Aug 19, 2024 · 2 comments

Comments

@abompard
Copy link
Member

There's a confusion between HostCountry and HostCountryAllowed in the UI. The list of allowed countries in the host form is taken from and populates the Host.countries attribute, which is for HostCountry, not HostCountryAllowed.
But HostCountryAllowed is the data that is used by generate-mirrorlist-cache for allowed countries.

We should fix the UI and migrate the data.
@abompard
Copy link
Member Author

@adrianreber Do you agree with my understanding of the code here? Or am I missing something?

@ott
Copy link
Contributor

ott commented Aug 19, 2024

As pointed out in pull request #268, there might be additional aspects to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abompard @ott