Adding Local Setup and Promtail configuration #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukinimod
reviewed
Mar 17, 2023
This was
linked to
issues
Mar 17, 2023
BlacCello
reviewed
Apr 13, 2023
There was a problem hiding this comment.
I am fine for now with the basic setup (not tested yet), but we have to merge a lot of configuration files and only change some settings via helm value files (this might lead to making shell scripts configurable with arguments).
Edit: WIl be handled with #138
|
Can you please add a README for the local setup? This makes testing this PR easier. EDIT: Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.