InputMethodEngine::keyEvent non-blocking?

[qingxiang-jia]

I just realized that the keyEvent function is non-blocking. So if the user types too fast, it's possible the first call to keyEvent isn't finish, and the second call already happened. Does this means keyEvent and any functions it calls needs to be thread safe?

Since keyEvent is non-blocking, does that mean if some function it calls will take a long time (e.g. making a network request), we can just let it block since when the user hits the key again, whether the time-consuming call finishes or not, keyEvent will be on another thread?

[wengxt]

no, fcitx is mostly single thread and uses main thread to process key event. it’s not like every key event will open a new thread

which means, if you block it, you will also block other app to fcitx event and everything. Please don’t do that.

[wengxt]

show me you diff, you're likely not adding log in the right place.

[qingxiang-jia]

Will do that when I go home. Thanks!

[qingxiang-jia]

Hi @wengxt , here is the diff: qingxiang-jia/full-cloud-pinyin@main...is-keyevent-async

[wengxt]

我觉得你应该注意到 keyEvent 有好多是提前返回而不会执行到 end 了吧。其实你想验证非常简单，只需要 --verbose=key_trace=5 来启动自然就可以看到所有按键事件的日志

[qingxiang-jia]

谢谢提醒, 之前没想到