Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip to first non-empty search tab? #583

Closed
thvitt opened this issue May 10, 2021 · 0 comments
Closed

skip to first non-empty search tab? #583

thvitt opened this issue May 10, 2021 · 0 comments
Assignees
@thvitt
Labels
c:search s:question

Comments

@thvitt
Copy link
Member

thvitt commented May 10, 2021

When we’re on the text tab and there are no text matches, but rather matches in, e.g., the metadata field, we could automatically switch to that tab to spare the user an extra click (and possible confusion by the 'empty' search results).

I am thinking of queries like Urfaust or typical metadata queries (secondary sigils etc.).

Might be an alternative to #582. But might also be mildly confusing or not what the user wants.
@thvitt thvitt self-assigned this May 10, 2021
@thvitt thvitt closed this as completed in 600b678 May 13, 2021
@thvitt thvitt mentioned this issue May 13, 2021
Closed
thvitt added a commit that referenced this issue May 13, 2021
@thvitt
Redirect to /query URL in shortcut case.
576249a 
This works around the problem with the solution for #583 that we cannot
access the URL fragment returned by the redirect using JS API.

It can be replaced by a call to the shortcut API outlined in
faustedition/faust-gen-html#654 once that is
in place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thvitt thvitt

Labels
c:search s:question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thvitt