Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require high minimum version of CPanel::JSON::XS? #32

Open
wolfsage opened this issue Mar 13, 2018 · 0 comments
Open

Require high minimum version of CPanel::JSON::XS? #32

wolfsage opened this issue Mar 13, 2018 · 0 comments

Comments

@wolfsage
Copy link
Collaborator

Once rurban/Cpanel-JSON-XS#105 is fixed, should we require that as a minimum version? Or recommend it?

That will mean we actually throw exceptions (instead of serialize to undef) if someone accidentally passes an object in, which I think is far better behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant