Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Fix build on Travis CI #23

Open
mateuspontes opened this issue Oct 4, 2019 · 5 comments
Open

Fix build on Travis CI #23

mateuspontes opened this issue Oct 4, 2019 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mateuspontes
Copy link
Collaborator

mateuspontes commented Oct 4, 2019

Tests are ok, but Travis CI is broken due to some unknown change.

@sarafonseca-123
Copy link

I will try to solve this one!

@Andy9822
Copy link

Andy9822 commented Oct 5, 2019

I may take a look too

Any news or progress that you may've done @sarafonseca-123 ?

@alvesgabriel
Copy link

First, I'm sorry about all this commits messages I'm trying find the problem in Travis. And I think find. The command @bandit -r . in Makefile is return error because insecurity.

@mateuspontes
Copy link
Collaborator Author

@alvesgabriel thanks for your help. No problem with commits because you always can do a git squash in the end :)

I think the problem is not related to bandit because it started a few commits early. You can checkout any commit before bandit, for example, a8dc7bb4f1.

@girol
Copy link

girol commented Oct 17, 2019

@alvesgabriel , just a small tip:

When redoing a commit, you can use --amend. Imagine this scenario:

  • Do some work
  • Commit work
  • Stuff breaks
  • Fix a typo or small change related to last commit

Here, just run this:

git add <your files>
git commit --amend

It will integrate your changes to the last commit

@mateuspontes mateuspontes added bug Something isn't working and removed hacktoberfest labels Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants