Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TestClient to automatically add raw_path to ASGI scope #2262

Open
vytas7 opened this issue Aug 10, 2024 · 0 comments · May be fixed by #2331
Open

Improve TestClient to automatically add raw_path to ASGI scope #2262

vytas7 opened this issue Aug 10, 2024 · 0 comments · May be fixed by #2331
Labels
enhancement good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks!
Milestone
Triaged (Non-Brea...

Comments

@vytas7
Copy link
Member

vytas7 commented Aug 10, 2024

Thanks to @liborjelinek, the WSGI flavour of the framework does this out of the box as per #2159.
To make things consistent, we ought to add raw_path to ASGI scope.
@vytas7 vytas7 added good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! enhancement needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! labels Aug 10, 2024
@vytas7 vytas7 added this to the Triaged (Non-Breaking Changes) milestone Aug 10, 2024
@aarcex3 aarcex3 linked a pull request Sep 17, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks!
Projects
None yet
Milestone
Triaged (Non-Breaking Changes)
Development

Successfully merging a pull request may close this issue.

feat(testing): add raw_path to ASGI scope aarcex3/falcon
1 participant
@vytas7