Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versionize xml #286

Open
maxnoe opened this issue Dec 11, 2017 · 1 comment
Open

Versionize xml #286

maxnoe opened this issue Dec 11, 2017 · 1 comment

Comments

@maxnoe
Copy link
Member

maxnoe commented Dec 11, 2017

Now that FACT-Tools can access it's own version in code, we could add a class, that checks the version and exits if it does not fit, like this:

<fact.RequireVersion version="1.0.0" />
  • XMLs used for thesis and publications state the FACT-Tools version that was used
  • Results become more reproducible

What do you think?

What would be the correct thing to use in streams, as it should raise the error as early as possible?
StatefulProcessors init method? A Service?

@tarrox
Copy link
Contributor

tarrox commented Dec 13, 2017

Using a Service should be the fastes as the services should get initialized before the processors. Also having the RequireVersion together with the variables and all, makes more sense as everyone is doing it that way (all other software). In addition this could be the first definition in the xml which is nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants