Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SinglePe extractor template maybe outdated #158

Open
jebuss opened this issue Oct 28, 2016 · 2 comments
Open

SinglePe extractor template maybe outdated #158

jebuss opened this issue Oct 28, 2016 · 2 comments

Comments

@jebuss
Copy link
Member

jebuss commented Oct 28, 2016

In the current version of fact.features.singlePulse.timeLineExtraction.TemplatePulse we use a template according to an old ceres.rc (The one from the Mars Trunk in svn). It looks like this:

PulseShape.Function.Name: (1.626*(1-exp(-0.3803*0.5*x))*exp(-0.0649*0.5*x))

In ceres12.rc the following template is used:

PulseShape.Function.Name: (1.239*(1-1/(1+exp((0.5*x-2.851)/1.063)))*exp(-(0.5*x-2.851)/19.173))

We should check the impact of these different functions to the extractors performance

@dneise
Copy link
Member

dneise commented Oct 31, 2016

I wanted to understand the difference, so I plotted them for me ... maybe this is interesting for other people as well:
two_funcs

The blue is the upper fomula, the green is the lower formula.

@relleums
Copy link
Member

I opt for exploring different pulse template shapes when we managed to close the loop with the simulation truth on the pulses from CERES/MARS. But it is good that we noticed this mismatch of the different pulse templates.

@jebuss jebuss added this to the 0.18.0 milestone Dec 6, 2016
@maxnoe maxnoe removed this from the 0.18.0 milestone Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants