Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Different settings in random_sized_crop #134

Open
wjfwzzc opened this issue Apr 19, 2021 · 0 comments
Open

Different settings in random_sized_crop #134

wjfwzzc opened this issue Apr 19, 2021 · 0 comments

Comments

@wjfwzzc
Copy link

wjfwzzc commented Apr 19, 2021

In pycls, aspect_ratio are sampled uniformly in linear space:

aspect_ratio = np.random.uniform(3.0 / 4.0, 4.0 / 3.0)

However in torchvision, aspect_ratio are sampled uniformly in log space:
https://github.com/pytorch/vision/blob/79ee22da44d43dabcc0fd30da2c914c5f04143eb/torchvision/transforms/transforms.py#L849-L854

So does timm:
https://github.com/rwightman/pytorch-image-models/blob/e8a64fb88108b592da192e98054095b1ee25e96e/timm/data/transforms.py#L106-L107

Seems that issue #123 reports the performance decrease. Could anyone check that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant