From 3ee52a9cff4769e4d49fbd1caa04266c62651b80 Mon Sep 17 00:00:00 2001 From: Shoufa Chen Date: Wed, 16 Nov 2022 11:06:42 +0800 Subject: [PATCH] remove unused code It seems that these lines are pointless. Removing these lines has no effect no matter whether` self.norm` is `None` or not. Besides, `self.norm` coundn't be `None` otherwise `intermediate.append(self.norm(output))` would be error. --- models/transformer.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/models/transformer.py b/models/transformer.py index dcd536750..0e0c383a2 100644 --- a/models/transformer.py +++ b/models/transformer.py @@ -112,12 +112,6 @@ def forward(self, tgt, memory, if self.return_intermediate: intermediate.append(self.norm(output)) - if self.norm is not None: - output = self.norm(output) - if self.return_intermediate: - intermediate.pop() - intermediate.append(output) - if self.return_intermediate: return torch.stack(intermediate)