Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

example-quick-start.php has parsing error #8

Open
2 tasks
vkama opened this issue May 29, 2017 · 1 comment
Open
2 tasks

example-quick-start.php has parsing error #8

vkama opened this issue May 29, 2017 · 1 comment

Comments

@vkama
Copy link
Contributor

vkama commented May 29, 2017

Need to make it so so the example is included into tests, this way, any refactoring issue or any coding problem should be validated.

Parse error: parse error in facebook-instant-articles-sdk-extensions-in-php/src/Facebook/InstantArticles/AMP/Examples/example-quick-start.php on line 61

Example has a missing ;

  • Add test case for example
  • Fix ';' refactoring issue.
@timjacobi
Copy link
Contributor

@vkama can you please have a look if we still need to track this issue given the above fixes?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants