Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

constraint on pipeline env map #155

Open
hrishin opened this issue Jan 14, 2019 · 2 comments
Open

constraint on pipeline env map #155

hrishin opened this issue Jan 14, 2019 · 2 comments
Labels
need-thinking🤔 We need to have some proper discussion about this before starting working on this

Comments

@hrishin
Copy link
Member

hrishin commented Jan 14, 2019

Pipeline env map should refere to only one environment of each type.

example.

env_map1 {
   .......
   environments: [
         env1
         env2
   ]
} 

Where env1 is type of stage and env2 of type of production.
What if use selects two stage types env while creating pipeline envs map, where env1 and env2 are type of stage

If this is a valid constraint, then API should do validate env map before creating/updating it.

@hrishin hrishin added the need-thinking🤔 We need to have some proper discussion about this before starting working on this label Jan 14, 2019
@chmouel
Copy link
Contributor

chmouel commented Jan 14, 2019

This is all coming from launcher (ie it will enforces it) but we can add a constraint if needed,

@hrishin
Copy link
Member Author

hrishin commented Jan 14, 2019

Agreed thats one option.
If pipeline env map is the source of truth in build service, then it's better to add a constraint on the build API side?
All API consumer (UI, app creation service) would behave consistently in that way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need-thinking🤔 We need to have some proper discussion about this before starting working on this
Projects
None yet
Development

No branches or pull requests

2 participants