Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Support 'Search' on Collaborators #707

Open
sbose78 opened this issue Oct 31, 2018 · 5 comments
Open

Support 'Search' on Collaborators #707

sbose78 opened this issue Oct 31, 2018 · 5 comments
Labels

Comments

@sbose78
Copy link
Member

sbose78 commented Oct 31, 2018

The front-end would need support for Search Space Collaborators in our backend API.
https://openshift.io/openshiftio/Openshift_io/plan/detail/942

Things to be considered:

  1. Do we wanna enhance the existing Collaborators API Endpoint?
  2. Or, do we wanna add a more generic search endpoint for searching role associations for any resource?
    Search/Filter assignees for a specific resource, by name/username/email...

I would go for the second one.

@sbose78
Copy link
Member Author

sbose78 commented Oct 31, 2018

What do you think? @sbryzak @dipak-pawar @xcoulon

@rohitkrai03
Copy link
Member

@sbose78 I like the second one as well.

@dipak-pawar
Copy link
Contributor

+1 for more generic search endpoint.

@sbryzak
Copy link
Member

sbryzak commented Oct 31, 2018

@sbose78 Will the endpoint be used for the determination of privileges in order for users to perform an action, or just for informational/management purposes?

@andrewazores
Copy link

The second option sounds like it could also lend itself to allowing a cleaner implementation of the "My Spaces" vs "Shared Spaces" distinction that is now made on the Spaces page. These buttons allow the table to toggle between showing Spaces that the logged in user owns vs ones that they are collaborators on (and do not own). Currently there's a bit of ugly logic that was implemented in order to get at the "collaborates but doesn't own" set:

https://github.com/fabric8-ui/fabric8-ui/blob/a9d4dfba30abe6bc16a40d97b1abdebf7d4d1030/src/app/profile/my-spaces/my-spaces.component.ts#L138

https://github.com/fabric8-ui/fabric8-ui/blob/a9d4dfba30abe6bc16a40d97b1abdebf7d4d1030/src/app/shared/user-spaces.service.ts#L97

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants