Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding typescript-css-modules plugin #44

Open
jcreamer898 opened this issue Dec 29, 2017 · 4 comments
Open

Consider adding typescript-css-modules plugin #44

jcreamer898 opened this issue Dec 29, 2017 · 4 comments

Comments

@jcreamer898
Copy link

First of all, love this starter! I have been playing with it for a few days and it works great.

We're using CSS modules and typescript on my team, and I created a plugin for allowing such a thing to work.

https://github.com/jcreamer898/gatsby-plugin-typescript-css-modules

If you would like to, you could add it to your gatsby-config.js in here.

I can do a PR for it if you wanna do it, otherwise, just an FYI that such a thing now exists. :)

@fabien0102
Copy link
Owner

Hello @jcreamer898,
Thank you for your feedback, it's always a pleasure to know that people use/like this starter 😃

I personnally prefer css in js, but very nice for your gatsby plugin, it's always good to have the choice 😉

I also prefer keep this starter simple, it's just a starter and it's really easy to add some plugin to gatsby if you want others features ^^

BTW, if you have a great site based on this starter, we can maybe add this one as an example (#42 ) 😉

Happy new year!

@jcreamer898
Copy link
Author

Well, just as an FYI, the Gatsby already supports CSS Modules out of the box...

https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/src/utils/webpack.config.js#L415

All that my plugin does is make sure that it works with TypeScript.

I could do an example for you potentially as well.

Thanks for making such a good starter. It really helped me grok Gatbsy!

@fabien0102
Copy link
Owner

mmm, good to know, so why not for a quick PR 😉 so anyone can easily use css (and it's optionnal, so good for me ;) )

@jcreamer898
Copy link
Author

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants