Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Over time increasing CPU and RAM usage #44

Open
sortofdev opened this issue Oct 30, 2019 · 0 comments
Open

Over time increasing CPU and RAM usage #44

sortofdev opened this issue Oct 30, 2019 · 0 comments

Comments

@sortofdev
Copy link

Using slsk-client over time creates huge increase in CPU and RAM usage 🔥. It got so bad that leaving my application running over night which is using this module had 100% CPU usage on one core and it would not come down. Thank god it was only using one core 😅

Took my time to debug this and found that peerSearchRequests array was collecting a lot of information. There seemed to be no other use for this array collection other then debugging (please correct me here). As a test i removed that part and issues CPU and RAM increase dropped drastically.

Here's a comparison where I'm only monitoring resource usage of a small application using slsk-client:
after

I'm creating a pull request in a moment and linking this issue with it.

In case this does not get merged anytime soon, feel free to use my fork (master branch) https://github.com/sortofdev/slsk-client which has a fix for this applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant