Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windowing should window along irregular CoordinateAxis #43

Open
cboulay opened this issue Nov 12, 2024 · 1 comment
Open

windowing should window along irregular CoordinateAxis #43

cboulay opened this issue Nov 12, 2024 · 1 comment

Comments

@cboulay
Copy link
Contributor

cboulay commented Nov 12, 2024

Windowing on irregular data precludes the windows from being stacked, meaning that we can no longer guarantee that each iteration returns a simple AxisArray. We might need unique methods for these different circumstances.

The unique methods will be much easier to implement after the refactor from generator methods to class objects.

@cboulay
Copy link
Contributor Author

cboulay commented Dec 23, 2024

One thing that will be tricky to handle is an incoming chunk that is longer than win_step. It's expected that an irregular-rate CoordinateAxis will have different numbers of samples per window, so we won't be able to yield a single AxisArray with multiple entries along the win axis.

Maybe it's enough to log a warning when the windowing generator func is configured in not 1:1 mode and the first incoming message's target axis is a CoordinateAxis. Then if we get a big data chunk that produces windows of different length then we raise an error.

I'd rather not support CoordinateAxis in non 1:1 mode because it will require yielding some container of multiple AxisArrays, which breaks compatibility with other processors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant