Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursion stops early #194

Open
SKelem opened this issue Nov 10, 2023 · 3 comments
Open

Recursion stops early #194

SKelem opened this issue Nov 10, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@SKelem
Copy link

SKelem commented Nov 10, 2023

I'm running version 0.5.4b5 on TB 115.4.2 (64-bit), on Ubuntu 23.10.

I have the option "[x] Search subfolders of selected top folder(s)" selected.

When I run Remove Duplicates on a folder, it processes subfolders until it finds finds one with duplicates, and then stops. It does not process all subfolders, and so it doesn't find all the duplicates. If I run Remove Duplicates again, on the same folder, it finds duplicates in other subfolders.

It should process all subfolders in one pass.

@eyalroz
Copy link
Owner

eyalroz commented Nov 10, 2023

The code does recurse all subfolders... perhaps this is a case of Thunderbird reporting the folders are empty rather than making the extension wait? Is this an IMAP account? Can you tell me which provider?

@dec3169
Copy link

dec3169 commented Nov 22, 2023

I have this same issue, running Ubuntu Mate 22.10 LTS, IMAP, and my providers are Namecheap (uses mail.privateemail.com), and my own IMAP server running dovecot.

It only sees one folder with duplicates, and when I run it again it goes to the next folder with duplicates. Both IMAP accounts have either a Current or Backup folder with several subfolders. I just copied a bunch of emails in each folder while backing up accounts, and each one had duplicates numbering in the hundreds to thousands.

The extension does find the duplicates, but it does not recurse like before. To be clear, I used to be able to search the Backup folder and it would find duplicates in subfolders Comms, Misc, Work, etc.. It would first do Comms, then once I deleted them a Misc window would come up, and so on. Now it will show me Comms, but when I delete the dupes I have to go do the remove duplicates again. It will then show me Misc, and exit again after I delete those dupes.

I am running 115.5.0 (64-bit).

@eyalroz
Copy link
Owner

eyalroz commented Sep 1, 2024

I'm sorry for the (very) long delay in replying.

  1. Do you remember, roughly, when the failure-to-recurse started occurring?
  2. When searching for dupes with a failing recursion, do you see any error messages added to the Error Console, which mention "Remove Duplicates" or "removedupes" anywhere? (Note that there are many messages already before the search starts).
  3. If you copy a folder hierarchy, on which the recursion fails, to the local folders - does the same problem occur there? If not, it might be some kind of issue relating to IMAP server timeouts.

@eyalroz eyalroz added the bug Something isn't working label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants