Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "duplicate removal" and conflict detection with extra compilation options #693

Open
eyalroz opened this issue Oct 21, 2024 · 0 comments

Comments

@eyalroz
Copy link
Owner

eyalroz commented Oct 21, 2024

Our compilation options structure supports appending arbitrary extra options. However, those options could potentially conflict, or repeat, options we set through the fields of the compilation_options_t structure; and CUDA's NVRTC can be rarther touchy about such cases.

We should offer the library user the ability to resolve these situations, i.e.:

  • Remove extra options which will be generated anyway on the command-line to due to non-extra option values.
  • Do something intelligent if an extran option conflicts with a non-extra-option field value: Throw an exception or use the extra option as an override (i.e. set the non-extra option)

I mulling over whether to split this bug into two, one for duplicate removal and one for conflict resolution; but since the code for both would probably be in the same place, let's keep it one bug for now.

Note that override application essentially requires full option parsing, while for the rest it is sufficient if we are able to render individual option values to strings. Regarding option parsing, see also #692 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant