Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where are the archive/sandpit files supposed to come from? #135

Open
ndw opened this issue Apr 6, 2022 · 5 comments
Open

Where are the archive/sandpit files supposed to come from? #135

ndw opened this issue Apr 6, 2022 · 5 comments

Comments

@ndw
Copy link

ndw commented Apr 6, 2022

There are tests in tests/qt3/archive that (seem to) rely on test1.zip and test3.zip existing in the sandpit directory. However, the sandpit directory is not in the repo and is explicitly .gitignored.

Where are they supposed to come from, and what are they supposed to contain?

@fgeorges
Copy link
Member

fgeorges commented Apr 6, 2022

Hi Norm! Good point. I think that either @johnlumley or @michaelhkay would be able to help?

@fgeorges
Copy link
Member

fgeorges commented Apr 6, 2022

Otherwise, you might be able to reverse-engineer it from tests/qt3/archive/archive.xml (test1.zip must have one entry, new.txt, with content Some text here encoded as UTF-8, etc.) It might get a bit trickier for other properties, like compression, etc.

@ndw
Copy link
Author

ndw commented Apr 7, 2022

Hmm. I was going to say that I had some files that seemed to work (I've been tidying up some parts of the Saxonica test harness), but the test1.zip that I have doesn't have a new.txt entry so perhaps I don't yet understand exactly how the tests work.

@michaelhkay
Copy link
Member

I found some files in a working copy of an old Subversion repository and have done a commit under a new name (sandpit2) but now realise these are probably the same files that Norm found, with no new.txt entry.

@fgeorges
Copy link
Member

fgeorges commented Apr 7, 2022

Don't take my comment about new.txt as the absolute truth, I was just having a quick look at the tests in tests/qt3/archive/archive.xml.

Actually, after a second look, I would rather say that it must be textA.txt and contain "A simple string". The entry new.txt seems to be created by one of the tests themselves (which makes more sense given its name.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants