You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 10, 2023. It is now read-only.
context
When I type an html comment in markdown. Consider a cell with this content:
A **repository**: a group of *linked* commits
<!-- offline:
![](files/images/threecommits.png)
<img src="https://raw.github.com/fperez/reprosw/master/fig/threecommits.png" >
-->
expectation
I expected it not to render the comment, and show only this:
bug
But instead it renders as:
problem
This is a problem b/c we often use comments to temporarily elide parts of a markdown cell or provide extra info not meant to be rendered.
Reproduce the bug
See above - happens with 0.1.3
Edit
Fixed accidentally incorrect screenie.
The text was updated successfully, but these errors were encountered:
In the event it helps: I've run into a version of the same bug. I had a markdown cell with the following HTML inside of it to render a resized image, which worked before installation of jupyterlab-mystjs:
Thanks @mcauthorn and @fperez for the feedback, we will aim to get this fixed up soon, I think we somehow need to enable the html parts:
@fwkoch I have put together a sandbox example here html-comments/images it does looks like they do get parsed to html, but I think we aren't taking them the rest of the way?
Hi @fperez and @mcauthorn -- there is a new version v0.1.4 that provides better support for HTML parsing. It does catch the comments, and those are now no longer rendered (thank you @fwkoch!).
There is also a new feature that you can partially disable the full-renderer, and opt instead to open a MyST and a traditional version of the same notebook through the UI. This will require you to explicitly disable the "plugin" part, this will enable the other renderer -- there is more info in the readme!
Describe the bug
context
When I type an html comment in markdown. Consider a cell with this content:
expectation
I expected it not to render the comment, and show only this:
bug
But instead it renders as:
problem
This is a problem b/c we often use comments to temporarily elide parts of a markdown cell or provide extra info not meant to be rendered.
Reproduce the bug
See above - happens with 0.1.3
Edit
Fixed accidentally incorrect screenie.
The text was updated successfully, but these errors were encountered: