Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch version update to 1.5.19 breaks BC #247

Open
digibeuk opened this issue Jul 24, 2020 · 1 comment
Open

patch version update to 1.5.19 breaks BC #247

digibeuk opened this issue Jul 24, 2020 · 1 comment

Comments

@digibeuk
Copy link

I noticed an update to 1.5.19 from 1.5.18 breaks BC because of the signature change in \EWZ\Bundle\RecaptchaBundle\Validator\Constraints\IsTrueValidator

it was introduced here :
1b3c8ca#diff-868e2d307410dbab0dd4664637452171

this does not comply with semantic versioning practices, any way you could reverse the change and/or add a nullable property to the constructor to support both situations?
@excelwebzone
Copy link
Owner

You are more then welcome to create a PR to fix this issue..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@excelwebzone @digibeuk