Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Both enabled and disabled buttons are shown irrespective of product status. #646

Open
saurabhshukla689 opened this issue Oct 6, 2024 · 6 comments
Assignees

Comments

@saurabhshukla689
Copy link

Describe the bug
In the admin app , in products grid page, when user tries to enable or disable an item, both enable and disable items are shown regardless of the state of the item( whether enabled or disabled).

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Catalog-> Products'
  2. Click on the checbox corresponding to one of the items
  3. Both disable and enable buttons are shown

Expected behavior
If the product is enabled , then only disabled option should be visible . If the product is disabled , then only enabled option should be visible. If more than one items are selected , both enable and disable items should be shown, and clicking either of them enables or disables all the products.
Screenshots
If applicable, add screenshots to help explain your problem.

Background (please complete the following information):

  • NodeJS Version - v18.19.1
  • Postgres Version - (PostgreSQL) 16.4
  • EverShop Version - latest
  • OS: Ubuntu
  • Browser Chrome
@saurabhshukla689
Copy link
Author

@treoden . If you dont mind , can you please assign this to me?
Thanks.

@saurabhshukla689
Copy link
Author

Hi @treoden . Could you please go through this issue and let me know your thoughts?

@GabrielGavrilov
Copy link
Contributor

GabrielGavrilov commented Oct 10, 2024

What if you select two products where one product is enabled and the other one is disabled?

@saurabhshukla689
Copy link
Author

Hi @GabrielGavrilov .
In the current implementation, if one product is enabled and another product is disabled, then also both options are seen.

And if enabled button is clicked all disabled products are enabled and enabled products remain as they are.
And vice versa.

The idea is to keep above functionality same and just change it when user selects only 1 product.

@saurabhshukla689
Copy link
Author

Hi @treoden .
Gentle reminder to let us know your thoughts on this.
Even if you think otherwise.

@treoden
Copy link
Collaborator

treoden commented Oct 17, 2024

Hi @saurabhshukla689 ,

Please give me some time, I will take a look this soon.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants